Enable Performance/MapCompact cop
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
added a commit
to koic/rubocop-rails_config
that referenced
this pull request
Apr 23, 2021
RuboCop does not support Ruby 2.4. rubocop/rubocop#9648 And toshimaru#111 requires this PR. Therefore, this PR drops support for Ruby 2.4 to enable the same cops as rails/rails.
|
RuboCop Performance 1.11 has dropped support for Ruby 2.4. #112 is required for the successful build of this PR. |
koic
force-pushed
the
enable_performance_map_compact_cop
branch
from
b2db297
to
5c3859a
Compare
koic
added a commit
to koic/rubocop-rails_config
that referenced
this pull request
Apr 23, 2021
RuboCop does not support Ruby 2.4 and rails/rails uses RuboCop 1.13. - rubocop/rubocop#9648 - rails/rails@bbbc861 And toshimaru#111 requires this PR. Therefore, this PR drops support for Ruby 2.4 to enable the same cops as rails/rails.
Follow rails/rails@bbbc861 This PR enables `Performance/MapCompact` cop and requires RuboCop Performance 1.11 or higher. Because `Performance/MapCompact` cop has introduced in RuboCop Performance 1.11.
koic
force-pushed
the
enable_performance_map_compact_cop
branch
from
5c3859a
to
a34c5bf
Compare
toshimaru
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow rails/rails@bbbc861
This PR enables
Performance/MapCompactcop and requires RuboCop Performance 1.11 or higher.Because
Performance/MapCompactcop has introduced in RuboCop Performance 1.11.