Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Lint/DuplicateMagicComment cop #154

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,7 @@ jobs:
matrix:
ruby: ['2.6', '2.7', '3.0', '3.1']
gemfile:
- gemfiles/rubocop_1.29.gemfile
- gemfiles/rubocop_1.30.gemfile
- gemfiles/rubocop_1.31.gemfile
- gemfiles/rubocop_1.32.gemfile
- gemfiles/rubocop_1.33.gemfile
- gemfiles/rubocop_1.34.gemfile
- gemfiles/rubocop_1.35.gemfile
- gemfiles/rubocop_1.36.gemfile
- gemfiles/rubocop_1.39.gemfile
toshimaru marked this conversation as resolved.
Show resolved Hide resolved
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion Appraisals
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

SUPPORTED_VERSIONS = %w[1.29 1.30 1.31 1.32 1.33 1.34 1.35 1.36].freeze
SUPPORTED_VERSIONS = %w[1.39].freeze

SUPPORTED_VERSIONS.each do |version|
appraise "rubocop-#{version}" do
Expand Down
3 changes: 3 additions & 0 deletions config/rails.yml
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,9 @@ Lint/AmbiguousRegexpLiteral:
Lint/DuplicateRequire:
Enabled: true

Lint/DuplicateMagicComment:
Enabled: true

Lint/DuplicateMethods:
Enabled: true

Expand Down
14 changes: 0 additions & 14 deletions gemfiles/rubocop_1.30.gemfile

This file was deleted.

14 changes: 0 additions & 14 deletions gemfiles/rubocop_1.31.gemfile

This file was deleted.

14 changes: 0 additions & 14 deletions gemfiles/rubocop_1.32.gemfile

This file was deleted.

14 changes: 0 additions & 14 deletions gemfiles/rubocop_1.33.gemfile

This file was deleted.

14 changes: 0 additions & 14 deletions gemfiles/rubocop_1.34.gemfile

This file was deleted.

14 changes: 0 additions & 14 deletions gemfiles/rubocop_1.35.gemfile

This file was deleted.

14 changes: 0 additions & 14 deletions gemfiles/rubocop_1.36.gemfile

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ gem "bundler"
gem "minitest"
gem "rake"
gem "rails", ">= 5.2"
gem "rubocop", "~> 1.29.0"
gem "rubocop", "~> 1.39.0"

gemspec path: "../"
2 changes: 1 addition & 1 deletion rubocop-rails_config.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Gem::Specification.new do |spec|
spec.license = "MIT"
spec.required_ruby_version = ">= 2.6.0"

spec.add_dependency "rubocop", ">= 1.29.0"
spec.add_dependency "rubocop", ">= 1.39.0"
spec.add_dependency "rubocop-ast", ">= 1.0.1"
spec.add_dependency "rubocop-minitest", "~> 0.22"
spec.add_dependency "rubocop-performance", "~> 1.11"
Expand Down