feat : 문장의 각 단어 중 첫 문자만 뽑는 함수추가 ( #128 이슈에 대한 ) #133

KNU-K · 2024-06-25T06:55:48Z

feat : 문장의 각 단어 중 첫 문자만 뽑는 함수추가

test 및 함수 추가

issue 를 보고 해당 PR을 추가하게되었습니다

Overview

문장 내에서 단어의 첫 문자만 뽑는 함수를 추가하였습니다.

PR Checklist

I read and included theses actions below

I have read the Contributing Guide
I have written documents and tests, if needed.

* test 및 함수 추가

changeset-bot · 2024-06-25T06:55:52Z

🦋 Changeset detected

Latest commit: 3ffcd89

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-06-25T06:55:52Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
es-hangul	❌ Failed (Inspect)			Jun 29, 2024 1:51pm

src/getFirstHangulLetters.ts

test 추가

KNU-K · 2024-06-28T18:05:58Z

@po4tion 추가했습니다. 확인 부탁드립니다.

src/getFirstHangulLetters.ts

src/_internal/hangul.ts

Co-authored-by: 박찬혁 <pgg6713@gmail.com>

getFirstHangulLetters -> getHangulAcronym

export function isHangulOnly로 변경

okinawaa

아래와 같은 lint오류 세가지가 발생하고 있어서, 해결부탁드립니다

KNU-K

수정했습니다

src/getHangulAcronym.ts

안쓰는 메소드 삭제

Co-authored-by: 박찬혁 <pgg6713@gmail.com>

okinawaa

긴 작업 감사합니다 🚀

codecov-commenter · 2024-06-29T13:52:00Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.79%. Comparing base (f0195b2) to head (3ffcd89).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   98.78%   98.79%           
=======================================
  Files          14       15    +1     
  Lines         247      249    +2     
  Branches       55       55           
=======================================
+ Hits          244      246    +2     
  Misses          3        3

KNU-K · 2024-06-29T13:53:12Z

@okinawaa 감사합니다.

* feat : 문장의 각 단어 중 첫 문자만 뽑는 함수추가 * test 및 함수 추가 * add : 한글 문장인지 여부 판별 함수 추가 * fix : 한글 문장인지 여부 판별 기저 및 오류 추가 / arg 이름 변경 test 추가 * fix: src/_internal/hangul.ts Co-authored-by: 박찬혁 <pgg6713@gmail.com> * fix : rename function getFirstHangulLetters -> getHangulAcronym * fix : rename function export function isHangulOnly로 변경 * fix : lint error * fix : index에 추가 * chore : doc 추가 * fix : 문서화 한글 영어 바뀐거 바로 변경 * fix : isHangul로 대체 toss#136 으로 * chore : doc수정 * Update docs/src/pages/docs/api/getHangulAcronym.en.mdx Co-authored-by: 박찬혁 <pgg6713@gmail.com> * fix : Update hangul.ts 안쓰는 메소드 삭제 * Update getHangulAcronym.ko.mdx * Update getHangulAcronym.en.mdx * Update src/getHangulAcronym.ts Co-authored-by: 박찬혁 <pgg6713@gmail.com> * Update src/getHangulAcronym.ts Co-authored-by: 박찬혁 <pgg6713@gmail.com> * Update getHangulAcronym.ts * Update getHangulAcronym.spec.ts * Create fair-brooms-drive.md --------- Co-authored-by: 박찬혁 <pgg6713@gmail.com>

* fix. 겹모음과 관련된 이상 현상들 수정 * fix. fix index * fix. 오타 수정 Co-authored-by: 박찬혁 <pgg6713@gmail.com> * fix. 오타 수정 Co-authored-by: 박찬혁 <pgg6713@gmail.com> * fix. 업데이트 로직 반영 * test: internal 테스트 코드를 작성합니다 (#137) * test: internal 테스트 코드를 작성합니다 * test: vitest에서 제공해주는 toThrowError로 변경 --------- Co-authored-by: 박찬혁 <pgg6713@gmail.com> * docs: josa에 관련된 문서에 잘못된 부분을 수정합니다 - '이에/에' 삭제 Co-authored-by: 박찬혁 <pgg6713@gmail.com> * chore: version packages (#143) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: 한글 문자열에 대한 검증, assert, parsing 함수를 구현합니다. (#136) * feat: 한글 문자열인지 boolean 반환 함수 * feat: 한글 문자열인지 assert 함수 * feat: stringify * test: isHangulString, assertHangulString 테스트 코드 * feat: parse 함수 * test: parse 함수 테스트 * refactor: naming 통일 * feat : 문장의 각 단어 중 첫 문자만 뽑는 함수추가 ( #128 이슈에 대한 ) (#133) * feat : 문장의 각 단어 중 첫 문자만 뽑는 함수추가 * test 및 함수 추가 * add : 한글 문장인지 여부 판별 함수 추가 * fix : 한글 문장인지 여부 판별 기저 및 오류 추가 / arg 이름 변경 test 추가 * fix: src/_internal/hangul.ts Co-authored-by: 박찬혁 <pgg6713@gmail.com> * fix : rename function getFirstHangulLetters -> getHangulAcronym * fix : rename function export function isHangulOnly로 변경 * fix : lint error * fix : index에 추가 * chore : doc 추가 * fix : 문서화 한글 영어 바뀐거 바로 변경 * fix : isHangul로 대체 #136 으로 * chore : doc수정 * Update docs/src/pages/docs/api/getHangulAcronym.en.mdx Co-authored-by: 박찬혁 <pgg6713@gmail.com> * fix : Update hangul.ts 안쓰는 메소드 삭제 * Update getHangulAcronym.ko.mdx * Update getHangulAcronym.en.mdx * Update src/getHangulAcronym.ts Co-authored-by: 박찬혁 <pgg6713@gmail.com> * Update src/getHangulAcronym.ts Co-authored-by: 박찬혁 <pgg6713@gmail.com> * Update getHangulAcronym.ts * Update getHangulAcronym.spec.ts * Create fair-brooms-drive.md --------- Co-authored-by: 박찬혁 <pgg6713@gmail.com> * chore: version packages (#145) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: 문자열에서 한글만 반환하는 extractHangul을 구현합니다. (#130) * feat: parseHangul * fix: parseHangul의 이름을 extractHangul로 수정 및 테스트 코드 보완 * test: 일관된 테스트 코드 작성이 될 수 있도록 describe 설명 수정 * test: 테스트 코드 수정 * docs: extractHangul의 문서 작성 * test: 테스트 문구 수정 * fix: index.ts에 export 추가 * Create fresh-students-sit.md --------- Co-authored-by: 박찬혁 <pgg6713@gmail.com> * chore: version packages (#146) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix : getHangulacronym함수를 acronymizeHangul 메서드로 대체합니다. (#148) * Update and rename getHangulAcronym.ts to acronymizeHangul.ts * Update and rename getHangulAcronym.spec.ts to acronymizeHangul.spec.ts * Update index.ts * Update and rename getHangulAcronym.en.mdx to acronymizeHangul.en.mdx * Update and rename getHangulAcronym.ko.mdx to acronymizeHangul.ko.mdx * Create odd-squids-sin.md --------- Co-authored-by: 박찬혁 <pgg6713@gmail.com> * chore: version packages (#150) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: amountToHangul이 소수점, 숫자도 대응할 수 있도록 수정 (#144) * fix: amountToHangul이 소수점, 숫자도 대응할 수 있도록 수정 * docs: amountToHangul의 영어 문서 작성 * Create famous-cheetahs-sneeze.md * Update famous-cheetahs-sneeze.md --------- Co-authored-by: 박찬혁 <pgg6713@gmail.com> * fix: packlint ESLint error (#149) * test: utils 기능들의 테스트 케이스를 개선합니다 (#151) * test: hasBatchim 함수의 테스트 케이스를 추가합니다 * test: hasSingleBatchim의 테스트 케이스를 추가합니다 * fix: nextra theme asset 개선 (#152) * chore: version packages (#153) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: 패키지가 노출하는 인터페이스를 명확히 하기 위해 index.ts를 named export로 수정합니다 (#157) * fix: exposing public apis strictly * Create wild-cows-juggle.md * chore: version packages (#160) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * docs: CONTRIBUTING.md 파일에 메서드 컨벤션을 작성합니다. (#132) * Update CONTRIBUTING.md * fix * write contribution.md Co-authored-by: Jonghyeon Ko <61593290+manudeli@users.noreply.github.com> Co-authored-by: Dongkyu Kim <55759551+po4tion@users.noreply.github.com> * Update .github/CONTRIBUTING.md Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com> * Update .github/CONTRIBUTING.md Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com> * Update .github/CONTRIBUTING.md Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com> --------- Co-authored-by: Jonghyeon Ko <61593290+manudeli@users.noreply.github.com> Co-authored-by: Dongkyu Kim <55759551+po4tion@users.noreply.github.com> Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com> * test: amountToHangul 테스트 추가 (#135) * test: amountToHangul 테스트 추가 * test: amountToHangul 테스트 코드 수정 * test: amountToHangul 테스트 코드 스타일 변경 * test: amountToHangul test 개선 * fix: assert.throws대신 vitest toThrow로 메서드 변경 * fix: vitest toThrowError 메서드로 변경 --------- Co-authored-by: kinndohyun <dohyun.kim@carbonsaurus.com> Co-authored-by: 박찬혁 <pgg6713@gmail.com> * fix: 소수점 추가 후 발생한 '영'읽기 버그 수정 (#159) * fix: 소수점 추가 후 발생한 '영'읽기 버그 수정 * Create big-cups-call.md --------- Co-authored-by: 박찬혁 <pgg6713@gmail.com> * docs: acronymizeHangul 리턴 타입 표기 수정 (#161) * chore: version packages (#163) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: 일관된 toThrowError 메서드 사용 (#166) Co-authored-by: kinndohyun <dohyun.kim@carbonsaurus.com> * chore(eslint): 의도치 않은 naming을 제거하기 위해 cspell 추가 (#164) * chore(eslint): add cspell to check bad naming * chore: update * Create grumpy-singers-love.md --------- Co-authored-by: 박찬혁 <pgg6713@gmail.com> Co-authored-by: Dongkyu Kim <po4tion0429@gmail.com> Co-authored-by: Jaemin Kim <jmkim326@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: seunghee <sa02045@naver.com> Co-authored-by: taehyun <126179088+KNU-K@users.noreply.github.com> Co-authored-by: SeongMin Kim <86355699+Collection50@users.noreply.github.com> Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com> Co-authored-by: Jonghyeon Ko <61593290+manudeli@users.noreply.github.com> Co-authored-by: Dongkyu Kim <55759551+po4tion@users.noreply.github.com> Co-authored-by: 김도현 <101170386+fe-dudu@users.noreply.github.com> Co-authored-by: kinndohyun <dohyun.kim@carbonsaurus.com> Co-authored-by: Song Hyo Jin <shj@xenosi.de> Co-authored-by: wnhlee <40269597+2wheeh@users.noreply.github.com>

feat : 문장의 각 단어 중 첫 문자만 뽑는 함수추가

c811e8d

* test 및 함수 추가

KNU-K requested review from okinawaa and raon0211 as code owners June 25, 2024 06:55

vercel bot had a problem deploying to Preview June 25, 2024 06:56 Failure

KNU-K mentioned this pull request Jun 25, 2024

[Feature]: 문장의 각 단어 중 첫 문자만 뽑는 함수 #128

Closed

po4tion reviewed Jun 27, 2024

View reviewed changes

src/getFirstHangulLetters.ts Outdated Show resolved Hide resolved

KNU-K added 2 commits June 29, 2024 03:04

add : 한글 문장인지 여부 판별 함수 추가

2b7fbd4

fix : 한글 문장인지 여부 판별 기저 및 오류 추가 / arg 이름 변경

cc53591

test 추가

vercel bot had a problem deploying to Preview June 28, 2024 18:05 Failure

KNU-K requested a review from po4tion June 28, 2024 18:11

okinawaa reviewed Jun 29, 2024

View reviewed changes

src/getFirstHangulLetters.ts Outdated Show resolved Hide resolved

okinawaa reviewed Jun 29, 2024

View reviewed changes

src/_internal/hangul.ts Outdated Show resolved Hide resolved

fix: src/_internal/hangul.ts

dcecb15

Co-authored-by: 박찬혁 <pgg6713@gmail.com>

vercel bot had a problem deploying to Preview June 29, 2024 12:17 Failure

KNU-K requested a review from okinawaa June 29, 2024 12:39

KNU-K added 3 commits June 29, 2024 21:50

fix : rename function

b31a5b3

getFirstHangulLetters -> getHangulAcronym

fix : rename function

2e2b134

export function isHangulOnly로 변경

Merge branch 'main' of https://github.com/KNU-K/es-hangul

ea4cb1b

vercel bot had a problem deploying to Preview June 29, 2024 12:51 Failure

Merge branch 'main' into main

83fd467

okinawaa requested changes Jun 29, 2024

View reviewed changes

vercel bot had a problem deploying to Preview June 29, 2024 12:53 Failure

KNU-K added 2 commits June 29, 2024 21:57

fix : lint error

7bd33ed

Merge branch 'main' of https://github.com/KNU-K/es-hangul

fffd30e

vercel bot had a problem deploying to Preview June 29, 2024 12:58 Failure

KNU-K requested a review from okinawaa June 29, 2024 12:59

KNU-K commented Jun 29, 2024

View reviewed changes

okinawaa reviewed Jun 29, 2024

View reviewed changes

src/getHangulAcronym.ts Outdated Show resolved Hide resolved

okinawaa reviewed Jun 29, 2024

View reviewed changes

src/getHangulAcronym.ts Outdated Show resolved Hide resolved

okinawaa reviewed Jun 29, 2024

View reviewed changes

src/getHangulAcronym.ts Outdated Show resolved Hide resolved

fix : Update hangul.ts

e409273

안쓰는 메소드 삭제

vercel bot had a problem deploying to Preview June 29, 2024 13:39 Failure

KNU-K added 2 commits June 29, 2024 22:40

Update getHangulAcronym.ko.mdx

4e4e5bd

Update getHangulAcronym.en.mdx

c6f1bc4

vercel bot had a problem deploying to Preview June 29, 2024 13:41 Failure

KNU-K and others added 2 commits June 29, 2024 22:41

Update src/getHangulAcronym.ts

ba3ed2a

Co-authored-by: 박찬혁 <pgg6713@gmail.com>

Update src/getHangulAcronym.ts

00b3560

Co-authored-by: 박찬혁 <pgg6713@gmail.com>

vercel bot had a problem deploying to Preview June 29, 2024 13:42 Failure

Update getHangulAcronym.ts

b7dd6a7

vercel bot had a problem deploying to Preview June 29, 2024 13:46 Failure

Update getHangulAcronym.spec.ts

a36ab58

vercel bot had a problem deploying to Preview June 29, 2024 13:48 Failure

KNU-K requested a review from okinawaa June 29, 2024 13:48

okinawaa previously approved these changes Jun 29, 2024

View reviewed changes

Create fair-brooms-drive.md

3ffcd89

okinawaa dismissed their stale review via 3ffcd89 June 29, 2024 13:50

vercel bot had a problem deploying to Preview June 29, 2024 13:51 Failure

okinawaa approved these changes Jun 29, 2024

View reviewed changes

okinawaa merged commit b0e1184 into toss:main Jun 29, 2024
8 of 9 checks passed

github-actions bot mentioned this pull request Jun 29, 2024

chore: version packages #145

Merged

KNU-K mentioned this pull request Jun 29, 2024

fix : getHangulacronym함수를 acronymizeHangul 메서드로 대체합니다. #148

Merged

1 task

okinawaa mentioned this pull request Jul 12, 2024

feat: 한글의 두음을 반환해주는 acronymizeHangul 함수를 제거합니다. #180

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat : 문장의 각 단어 중 첫 문자만 뽑는 함수추가 ( #128 이슈에 대한 ) #133

feat : 문장의 각 단어 중 첫 문자만 뽑는 함수추가 ( #128 이슈에 대한 ) #133

KNU-K commented Jun 25, 2024 •

edited

Loading

changeset-bot bot commented Jun 25, 2024 •

edited

Loading

vercel bot commented Jun 25, 2024 •

edited

Loading

KNU-K commented Jun 28, 2024

okinawaa left a comment

KNU-K left a comment

okinawaa left a comment

codecov-commenter commented Jun 29, 2024

KNU-K commented Jun 29, 2024

feat : 문장의 각 단어 중 첫 문자만 뽑는 함수추가 ( #128 이슈에 대한 ) #133

feat : 문장의 각 단어 중 첫 문자만 뽑는 함수추가 ( #128 이슈에 대한 ) #133

Conversation

KNU-K commented Jun 25, 2024 • edited Loading

Overview

PR Checklist

changeset-bot bot commented Jun 25, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Jun 25, 2024 • edited Loading

KNU-K commented Jun 28, 2024

okinawaa left a comment

Choose a reason for hiding this comment

KNU-K left a comment

Choose a reason for hiding this comment

okinawaa left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jun 29, 2024

Codecov Report

KNU-K commented Jun 29, 2024

KNU-K commented Jun 25, 2024 •

edited

Loading

changeset-bot bot commented Jun 25, 2024 •

edited

Loading

vercel bot commented Jun 25, 2024 •

edited

Loading