chore: cspell.json 으로 설정을 변경합니다. #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 260 260
Branches 58 58
=========================================
Hits 260 260 |
minsoo-web
commented
Jul 5, 2024
Comment on lines
-69
to
-78
| '@cspell/spellchecker': [ | ||
| 'error', | ||
| { | ||
| cspell: { | ||
| words: ['choseong', 'jungseong', 'jongseong'], | ||
| // eslint-disable-next-line @cspell/spellchecker | ||
| flagWords: ['chosung', 'jungsung', 'jongsung'], | ||
| }, | ||
| }, | ||
| ], |
There was a problem hiding this comment.
#138 PR에서 chosung, jungsung, jongsung 은 deprecated 되어 하위호환성을 지키는 방향으로 유지됩니다.
cspell 을 error 로 설정하게 될 경우, github username 을 일일이 등록해야 하거나, 테스트 코드에서도 예외처리를 해줘야 하는등 오히려 불편함을 야기하기 쉽습니다. warning 으로 충분하다고 생각하여, 에러 표기를 지우게 되었습니다.
okinawaa
approved these changes
Jul 9, 2024
Collection50
pushed a commit
to Collection50/es-hangul
that referenced
this pull request
Jul 9, 2024
okinawaa
added a commit
that referenced
this pull request
Jul 13, 2024
* fix: 일관된 한글 표기법 적용 * fix: 기존의 함수를 유지한 채, deprecated 되도록 수정 * fix: main 브랜치와 merge를 위한 수정 * fix: conflict 수정 * fix: 문서에는 chosung prefix를 사용하도록 수정 * fix: ChoseongIncludesDemo 함수명 수정 * chore: cspell.json 으로 설정을 변경합니다. (#172) * fix: 일관된 한글 표기법 적용 * fix: 기존의 함수를 유지한 채, deprecated 되도록 수정 * docs: chosung~ 문서 작성 * fix: choseongIncludes의 인덱싱 처리 * Create fifty-wolves-melt.md * fix: import CI 오류 해결 --------- Co-authored-by: Minsoo Kim <57122180+minsoo-web@users.noreply.github.com> Co-authored-by: 박찬혁 <pgg6713@gmail.com>
okinawaa
added a commit
that referenced
this pull request
Jul 13, 2024
* fix: 일관된 한글 표기법 적용 * fix: 기존의 함수를 유지한 채, deprecated 되도록 수정 * fix: main 브랜치와 merge를 위한 수정 * fix: conflict 수정 * fix: 문서에는 chosung prefix를 사용하도록 수정 * fix: ChoseongIncludesDemo 함수명 수정 * chore: cspell.json 으로 설정을 변경합니다. (#172) * fix: 일관된 한글 표기법 적용 * fix: 기존의 함수를 유지한 채, deprecated 되도록 수정 * docs: chosung~ 문서 작성 * fix: choseongIncludes의 인덱싱 처리 * Create fifty-wolves-melt.md * fix: import CI 오류 해결 --------- Co-authored-by: Minsoo Kim <57122180+minsoo-web@users.noreply.github.com> Co-authored-by: 박찬혁 <pgg6713@gmail.com>
okinawaa
added a commit
that referenced
this pull request
Jul 13, 2024
* fix: 일관된 한글 표기법 적용 * fix: 기존의 함수를 유지한 채, deprecated 되도록 수정 * fix: main 브랜치와 merge를 위한 수정 * fix: conflict 수정 * fix: 문서에는 chosung prefix를 사용하도록 수정 * fix: ChoseongIncludesDemo 함수명 수정 * chore: cspell.json 으로 설정을 변경합니다. (#172) * fix: 일관된 한글 표기법 적용 * fix: 기존의 함수를 유지한 채, deprecated 되도록 수정 * docs: chosung~ 문서 작성 * fix: choseongIncludes의 인덱싱 처리 * Create fifty-wolves-melt.md * fix: import CI 오류 해결 --------- Co-authored-by: Minsoo Kim <57122180+minsoo-web@users.noreply.github.com> Co-authored-by: 박찬혁 <pgg6713@gmail.com>
okinawaa
added a commit
that referenced
this pull request
Jul 14, 2024
* docs * Update docs/src/pages/docs/introduction.ko.mdx Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com> * Update docs/src/pages/index.ko.mdx Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com> * chore: version packages (#183) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: 일관된 한글 표기법 적용 (#138) * fix: 일관된 한글 표기법 적용 * fix: 기존의 함수를 유지한 채, deprecated 되도록 수정 * fix: main 브랜치와 merge를 위한 수정 * fix: conflict 수정 * fix: 문서에는 chosung prefix를 사용하도록 수정 * fix: ChoseongIncludesDemo 함수명 수정 * chore: cspell.json 으로 설정을 변경합니다. (#172) * fix: 일관된 한글 표기법 적용 * fix: 기존의 함수를 유지한 채, deprecated 되도록 수정 * docs: chosung~ 문서 작성 * fix: choseongIncludes의 인덱싱 처리 * Create fifty-wolves-melt.md * fix: import CI 오류 해결 --------- Co-authored-by: Minsoo Kim <57122180+minsoo-web@users.noreply.github.com> Co-authored-by: 박찬혁 <pgg6713@gmail.com> * english * Update docs/src/pages/docs/introduction.ko.mdx Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com> * english * Update docs/src/pages/index.ko.mdx * Update docs/src/pages/docs/introduction.ko.mdx --------- Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
PR Checklist