Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: numberToHangul 테스트 커버리지 보강 #298

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

po4tion
Copy link
Collaborator

@po4tion po4tion commented Nov 28, 2024

Overview

ASIS.
image

TOBE.
image

유효하지 않은 숫자에 대한 오류 처리 로직을 추가하였습니다. 또한, 내부 로직상 9999가 넘을수가 없어 기존의 에러 던지기는 제거하였습니다.

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

@po4tion po4tion self-assigned this Nov 28, 2024
Copy link

changeset-bot bot commented Nov 28, 2024

⚠️ No Changeset found

Latest commit: 55ca310

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 11:27am

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (2e5967c) to head (55ca310).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
+ Coverage   99.53%   99.84%   +0.31%     
==========================================
  Files          38       37       -1     
  Lines         642      641       -1     
  Branches      156      155       -1     
==========================================
+ Hits          639      640       +1     
+ Misses          3        1       -2     

Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

더 앞단에서 검증하니 좋네요!

@okinawaa okinawaa merged commit bc2f19b into main Nov 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants