-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: combineVowels 리턴 타입 보강 #308
fix: combineVowels 리턴 타입 보강 #308
Conversation
🦋 Changeset detectedLatest commit: 110460e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
좋은 작업해주셔서 감사합니다! 혹시 |
기존의 위 두 줄을
이렇게 고치면 조금 더 짧아질 것 같긴 합니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skiende74 님 좋은 의견 감사합니다!
@okinawaa 님 확인 부탁드립니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
작업 감사합니다!
Overview
combineVowels
의 리턴타입을 제네릭을 통해 type-narrowing 하도록 개선합니다.PR Checklist