Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving fill Function to Support Negative Indices #159

Closed
wondonghwi opened this issue Jul 11, 2024 · 1 comment
Closed

Improving fill Function to Support Negative Indices #159

wondonghwi opened this issue Jul 11, 2024 · 1 comment

Comments

@wondonghwi
Copy link
Contributor

wondonghwi commented Jul 11, 2024

Currently, the fill function in lodash and the toFilled function in esToolkit support negative indices. However, the fill function in esToolkit does not support negative indices. Enhancing the fill function to support negative indices will ensure consistency with the fill function in lodash and the toFilled function in esToolkit.

To maintain consistency, we propose enhancing the fill function in esToolkit to support negative indices, similar to the fill function in lodash and the toFilled function in esToolkit. For more details, please refer to the discussion here.

Would it be okay if I proceed with the improvements to the fill function?

@raon0211
Copy link
Collaborator

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants