feat(toFilled): add toFilled

[wondonghwi]

close: #118

The fill function was added to es-toolkit, and since fill mutates the original array, a new function that does not modify the original array was needed. To address this, we added a new function, toFilled.

I have added a function called toFilled that does not modify the original array. This function fills a specified portion of an array with a given value but returns a new array instead of modifying the original one. Additionally, this function allows for the use of negative indices, meaning you can specify positions from the end of the array backward. The toFilled function works similarly to the fill function but stands out by not altering the original array.

In the benchmark results, since lodash does not have a toFilled function, I compared it with lodash’s fill function. The comparison showed that the toFilled function performed better in terms of performance.

The implementation of this function was inspired by this issue.

[vercel]

@wondonghwi is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d48900f) to head (0899f52).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #154   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           73        74    +1     
  Lines          409       417    +8     
  Branches        54        57    +3     
=========================================
+ Hits           409       417    +8     

[raon0211]

Thanks for your great contribution!

I wanted to discuss the behavior of toFilled in comparison to the original fill function.

One key difference I've noticed is that fill supports negative indices, whereas toFilled does not. Since lodash's fill function does not support negative indices, I believe toFilled should follow and not support them either.

What are your thoughts on this?

[wondonghwi]

Hello @raon0211,

Based on my observations and tests, it appears that Lodash's fill function does indeed support negative indices. Given this, it seems appropriate that toFilled, as well as esToolkit's fill function, should also support negative indices to maintain consistency. Here is an example that demonstrates the behavior:

Given this behavior, I believe it would be beneficial to enhance both toFilled and esToolkit's fill functions to support negative indices. I would be interested in working on this enhancement if it is deemed necessary. What are your thoughts on this?

[raon0211]

Looks good to me!

[raon0211]

Given this behavior, I believe it would be beneficial to enhance both toFilled and esToolkit's fill functions to support negative indices.

Got this. Could you fix the behavior for fill, too?

[wondonghwi]

@raon0211

Sure :)

I will raise this issue and proceed to modify the fill function accordingly!