Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for countBy #88

Closed
raon0211 opened this issue Jun 28, 2024 · 2 comments · Fixed by #117
Closed

Support for countBy #88

raon0211 opened this issue Jun 28, 2024 · 2 comments · Fixed by #117

Comments

@raon0211
Copy link
Collaborator

Support for countBy is needed (except it does not accept strings in the second argument).
@raon0211 raon0211 mentioned this issue Jun 28, 2024
Open
@l2hyunwoo
Copy link
Contributor

🙋‍♂️

@raon0211
Copy link
Collaborator Author

Sure!

l2hyunwoo added a commit to l2hyunwoo/es-toolkit that referenced this issue Jul 2, 2024
@l2hyunwoo
[feature/toss#88] Add countBy.ts
77e6e01
l2hyunwoo added a commit to l2hyunwoo/es-toolkit that referenced this issue Jul 2, 2024
@l2hyunwoo
[feature/toss#88] Add benchmark test of countBy
9f86da7
l2hyunwoo added a commit to l2hyunwoo/es-toolkit that referenced this issue Jul 2, 2024
@l2hyunwoo
[feature/toss#88] Add test code
9593b30
l2hyunwoo added a commit to l2hyunwoo/es-toolkit that referenced this issue Jul 2, 2024
@l2hyunwoo
[feature/toss#88] Add countBy references
cc3f650
@l2hyunwoo l2hyunwoo mentioned this issue Jul 2, 2024
Merged
raon0211 added a commit that referenced this issue Jul 3, 2024
@l2hyunwoo @raon0211
feat(countBy): Add countBy function (#117)
373d63b 
* [feature/#88] Add countBy.ts

* [feature/#88] Add benchmark test of countBy

* [feature/#88] Add test code

* [feature/#88] Add countBy references

* Update docs/ko/reference/array/countBy.md

* Apply suggestions from code review

---------

Co-authored-by: Sojin Park <raon0211@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(countBy): Add countBy function l2hyunwoo/es-toolkit
2 participants
@raon0211 @l2hyunwoo