Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forEachRight): add forEachRight #119

Merged
merged 7 commits into from
Jul 3, 2024

Conversation

haejunejung
Copy link
Contributor

closes: #107

I have implemented a forEachRight function to address the requirements outlined in issue #107.

image

Copy link

vercel bot commented Jul 3, 2024

@haejunejung is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

raon0211
raon0211 previously approved these changes Jul 3, 2024
Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for your contribution!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (834d50c) to head (b4978b4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #119   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        63    +1     
  Lines          338       342    +4     
  Branches        39        39           
=========================================
+ Hits           338       342    +4     

@raon0211 raon0211 merged commit ba1e976 into toss:main Jul 3, 2024
7 of 8 checks passed
Copy link

codspeed-hq bot commented Jul 3, 2024

CodSpeed Performance Report

Merging #119 will degrade performances by 81.4%

Comparing haejunejung:feat/forEachRight (b4978b4) with main (834d50c)

Summary

⚡ 3 improvements
❌ 11 regressions
✅ 100 untouched benchmarks

🆕 2 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main haejunejung:feat/forEachRight Change
lodash 49.2 µs 209.9 µs -76.53%
lodash/differenceBy 348.2 µs 227.8 µs +52.86%
🆕 es-toolkit/forEachRight N/A 38.1 µs N/A
🆕 lodash/forEachRight N/A 323.6 µs N/A
lodash/intersectionBy 308.2 µs 444.9 µs -30.71%
lodash/isNil 35.4 µs 190.2 µs -81.4%
lodash/keyBy 215.6 µs 58.7 µs ×3.7
lodash/pick 86.3 µs 251 µs -65.6%
es-toolkit/range 39.3 µs 48.5 µs -18.87%
lodash/range 33.6 µs 44.2 µs -23.98%
lodash/shuffle 42.6 µs 195.3 µs -78.17%
lodash/union 232.6 µs 354.3 µs -34.34%
es-toolkit/uniqBy 16.5 ms 6.7 ms ×2.5
lodash/xorBy 90.8 µs 254.3 µs -64.3%
lodash/zip 242.5 µs 381.4 µs -36.42%
lodash/zipWith 254.1 µs 406.9 µs -37.57%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for forEachRight
3 participants