Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(negate): add negate base lodash implement #177

Merged
merged 7 commits into from
Jul 14, 2024
Merged

Conversation

CreeJee
Copy link

@CreeJee CreeJee commented Jul 13, 2024

This PR adds the negate function to the codebase. The negate function creates a function that negates the result of the predicate function passed to it. This can be useful for scenarios where the inverse logic of a given predicate is needed. Additionally, this PR includes comprehensive tests and detailed documentation for the negate function.

Changes

  • Added the negate function.
  • Created test cases for negate using vitest to ensure the function works correctly for various scenarios.
  • Added detailed documentation for the negate function in markdown format.

Please review the changes and provide feedback or approval for merging. Thank you!

@CreeJee CreeJee requested a review from raon0211 as a code owner July 13, 2024 07:22
Copy link

vercel bot commented Jul 13, 2024

@CreeJee is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

src/function/index.ts Outdated Show resolved Hide resolved
src/function/negate.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello :) Thanks for your contribution!

Meanwhile, I thought negate should only accept functions which return booleans for explicitness. We might support functions returning other values in es-toolkit/compat.

@raon0211 raon0211 merged commit bda3bef into toss:main Jul 14, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants