perf(difference): Optimize difference
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@po4tion is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
po4tion
changed the title
raon0211
changed the title
raon0211
changed the title
difference
raon0211
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The es-toolkit's
differencefunction becomes slower compared to lodash'sdifferenceas the array size increases.Therefore, I have modified the
differencefunction in es-toolkit so that it performs faster even as the array size increases.I have reduced the time complexity from O(n*m) to O(n+m).
AS-IS benchmark(es-toolkit vs lodash)
firstArr's size : 10
secondArr's size : 5
firstArr's size : 500
secondArr's size : 250
TO-BE benchmark(es-toolkit vs lodash)
firstArr's size : 10
secondArr's size : 5
firstArr's size : 500
secondArr's size : 250
Benchmark(old difference vs new difference)
firstArr's size : 10
secondArr's size : 5
firstArr's size : 500
secondArr's size : 250
firstArr's size : 10,000
secondArr's size : 5,000