Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(defaults): add defaults in compat layer #641

Merged
merged 7 commits into from
Oct 3, 2024

Conversation

dayongkr
Copy link
Contributor

@dayongkr dayongkr commented Oct 2, 2024

Description

I added defaults in compat layer.

Benchmark

Screenshot 2024-10-02 at 3 55 05 PM

Additional

I am wondering if it is also necessary for es-toolkit/object. If so, do you think it is appropriate to implement it in a way that does not mutate object? I would like to hear some opinions.

related #639

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 8:33am

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (0e7ad28) to head (8273de0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #641   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         535      537    +2     
  Lines       11230    11271   +41     
  Branches      803      806    +3     
=======================================
+ Hits        11108    11149   +41     
  Misses        121      121           
  Partials        1        1           

Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for your contribution!

@raon0211 raon0211 merged commit c6130a4 into toss:main Oct 3, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants