-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(defaults): add defaults
in compat layer
#641
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
=======================================
Coverage 98.91% 98.91%
=======================================
Files 535 537 +2
Lines 11230 11271 +41
Branches 803 806 +3
=======================================
+ Hits 11108 11149 +41
Misses 121 121
Partials 1 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for your contribution!
Description
I added
defaults
in compat layer.Benchmark
Additional
I am wondering if it is also necessary for
es-toolkit/object
. If so, do you think it is appropriate to implement it in a way that does not mutateobject
? I would like to hear some opinions.related #639