Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eq): add eq in compat layer #642

Merged
merged 2 commits into from
Oct 3, 2024
Merged

feat(eq): add eq in compat layer #642

merged 2 commits into from
Oct 3, 2024

Conversation

dayongkr
Copy link
Contributor

@dayongkr dayongkr commented Oct 2, 2024

Description

I added eq in compat layer. It performs a SameValueZero comparison.

I think it also needs in es-tookit/util, but we don't have a util folder in es-toolkit. So I added it in compat layer at first.

Benchmark

Screenshot 2024-10-02 at 7 58 15 PM

It is a tiny function. So this performance is equal with lodash.

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 8:28am

Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raon0211 raon0211 merged commit 0e7ad28 into toss:main Oct 3, 2024
5 of 8 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (458d0bf) to head (f5449c5).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #642      +/-   ##
==========================================
+ Coverage   98.90%   98.91%   +0.01%     
==========================================
  Files         531      535       +4     
  Lines       11194    11230      +36     
  Branches      801      803       +2     
==========================================
+ Hits        11071    11108      +37     
+ Misses        122      121       -1     
  Partials        1        1              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants