Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minBy): Add minBy function that select element that have min value by given condition in array #71

Merged
merged 6 commits into from
Jun 17, 2024

Conversation

l2hyunwoo
Copy link
Contributor

close #65

I added a function that select element that have min value by given condition in array.

스크린샷 2024-06-17 오후 5 14 46 스크린샷 2024-06-17 오후 5 15 01
  • If input array is not empty, return first element of array that have minimum value that satisfies given condition
  • If input array is empty, return undefined

Copy link

vercel bot commented Jun 17, 2024

@l2hyunwoo is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

src/math/minBy.ts Outdated Show resolved Hide resolved
raon0211
raon0211 previously approved these changes Jun 17, 2024
Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @l2hyunwoo !

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3ecc062) to head (d253a58).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        50    +1     
  Lines          244       253    +9     
  Branches        27        28    +1     
=========================================
+ Hits           244       253    +9     

@raon0211 raon0211 merged commit 860fb0c into toss:main Jun 17, 2024
1 of 2 checks passed
@l2hyunwoo l2hyunwoo deleted the feature/#65 branch June 17, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for minBy
3 participants