Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(groupBy): Accept number and symbol keys in groupBy #99

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

mass2527
Copy link
Contributor

I think groupBy, like keyBy, should also accept number and symbol keys.

@mass2527 mass2527 requested a review from raon0211 as a code owner June 30, 2024 05:50
Copy link

vercel bot commented Jun 30, 2024

@mass2527 is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fc1a8e6) to head (517401f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #99   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines          299       299           
  Branches        35        35           
=========================================
  Hits           299       299           

Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raon0211 raon0211 merged commit 044002e into toss:main Jun 30, 2024
7 of 8 checks passed
@jgjgill
Copy link
Contributor

jgjgill commented Jun 30, 2024

@mass2527 @raon0211 oh, I think the interface part of the docs should be changed as well. 🧐

  • groupBy (ko, en)
  • keyBy (ko, en)
스크린샷 2024-06-30 오후 3 01 16

@mass2527
Copy link
Contributor Author

@mass2527 @raon0211 oh, I think the interface part of the docs should be changed as well. 🧐

  • groupBy (ko, en)
  • keyBy (ko, en)
스크린샷 2024-06-30 오후 3 01 16

@jgjgill
I will fix this, thanks!

@mass2527 mass2527 deleted the feat/groupBy branch June 30, 2024 06:07
Copy link

codspeed-hq bot commented Jun 30, 2024

CodSpeed Performance Report

Merging #99 will degrade performances by 78.06%

Comparing mass2527:feat/groupBy (517401f) with main (a9e317b)

Summary

⚡ 2 improvements
❌ 9 regressions
✅ 85 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main mass2527:feat/groupBy Change
lodash 49.3 µs 56.4 µs -12.67%
lodash/difference 56.7 µs 210.1 µs -73.02%
lodash/differenceWith 69.2 µs 223.3 µs -69.02%
lodash/intersectionBy 518.1 µs 308.7 µs +67.81%
lodash/intersectionWith 92.2 µs 245.6 µs -62.48%
lodash/shuffle 42.9 µs 195.4 µs -78.06%
lodash/union 75.8 µs 231.9 µs -67.33%
lodash/unionBy 75.2 µs 229.5 µs -67.24%
lodash/unionWith 84.9 µs 239.9 µs -64.6%
lodash/xorBy 93.5 µs 251.5 µs -62.83%
lodash/zip 363.4 µs 243.2 µs +49.41%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants