Skip to content

Conversation

Seol-JY
Copy link
Contributor

@Seol-JY Seol-JY commented Jan 31, 2025

πŸ“ Key Changes

Fixes three syntax issues:

  • Adds missing period in email validation message - c4bda53
  • Adds missing 'from' keyword in import statement - db0a870
  • Changes requiring discussion:

πŸ–ΌοΈ Before and After Comparison

Simple text corrections in documentation files. No visual changes.

Copy link

vercel bot commented Jan 31, 2025

@Seol-JY is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.


```typescript
import { useFoo } '../../../Domain2/hooks/useFoo'
import { useFoo } from '../../../Domain2/hooks/useFoo'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

Copy link
Collaborator

@milooy milooy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ¦…

@milooy milooy merged commit 2f196fd into toss:main Feb 2, 2025
1 check failed
Kyujenius pushed a commit to Kyujenius/frontend-fundamentals that referenced this pull request Feb 3, 2025
* fix: Add missing 'from' keyword in import statement

* fix: Add missing period in email validation error message(ko)

* fix: add auth token to HTTP header
milooy pushed a commit that referenced this pull request Feb 4, 2025
* fix: change LCP image from png to webp

* docs: 간체 쀑ꡭ어 λ²ˆμ—­ (#120)

* chore: create ch files

* docs: translate into simplified chinese

* docs: translate into simplified chinese

* docs: translate into simplified chinese

* docs: translate into simplified chinese

* docs: translate into simplified chinese

* docs: translate into simplified chinese

* refactor: substitute with suitable terms

* docs: translate into simplified chinese

* feat: add chSearch

* fix: change chSearch option

* fix: fix typo with inspection

* οΏ½fix: fix typo in hidden-logic.md

εŒζ—Ά -> εŒδΊ‹

Co-authored-by: Jinyeong Seol <wlsdud5654@gmail.com>

* feat: implement dark mode image support in markdown

* docs: improve item-edit-modal.md by adding abstraction concepts

* fix: correct localized link

---------

Co-authored-by: Jinyeong Seol <wlsdud5654@gmail.com>

* Fix: Corrected localized link to Amazon (#141)

- The link was still redirecting to Yes24, so the link was updated properly

* Fix: Correct import path and Add Chinese on Giscus language  (#144)

* Fix: Ensure Giscus supports Chinese
* Fixed an issue where the Chinese locale was not applied in Giscus

* Fix: Correct import path for Chinese locale
* Fixed an incorrect import path in  ( β†’ ).

* Revert: yarn.lock

* οΏ½Fix: Add missing syntax and normalize Auth Token usage (#145)

* fix: Add missing 'from' keyword in import statement

* fix: Add missing period in email validation error message(ko)

* fix: add auth token to HTTP header

* fix: resolve badge component rendering issue by extending default theme (#146)

* feat: add webp Image in chinese ver.

---------

Co-authored-by: Owon <chlehdnjs@gmail.com>
Co-authored-by: Jinyeong Seol <wlsdud5654@gmail.com>
Co-authored-by: 𝒄𝒍 π’Š 𝒄 𝒆 <131771046+clicelee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants