Skip to content

Conversation

clicelee
Copy link
Contributor

@clicelee clicelee commented Feb 8, 2025

📝 Key Changes

Reference: #144 discussion

This PR renames all instances of ch to follow the correct locale standard:

  • Folder and link names have been updated to zh-hans to align with the proper locale format.
  • Variable names have been updated to zhHans where hyphens (-) are not allowed in TypeScript.
  • Giscus exception: The locale key for Giscus follows its official convention (zh-CN), based on giscus/giscus#i18n.tsx.

🔧 Changes:

  • Updated ch folder and links to zh-hans.
  • Renamed ch variables to zhHans to comply with TypeScript restrictions.
  • Ensured Giscus continues using zh-CN per its official standard

🖼️ Before and After Comparison

Renamed files and variables in Chinese documentation. No visual changes.

Copy link

vercel bot commented Feb 8, 2025

@clicelee is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@clicelee clicelee changed the title Docs: Rename ch to zh-Hans and zhHans Docs: Rename ch to zh-hans and zhHans Feb 8, 2025
Copy link
Member

@Kimbangg Kimbangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Kimbangg Kimbangg merged commit 47c6e34 into toss:main Feb 11, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants