refactor(buildContext): added displayName and fixed useInnerContext branch handling #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
buildContextexample documentIn the example,
nullis passed as the second argument, but since the signature ofbuildContextis as follows,nullcannot be passed.Also, since we used the
<{ title: string }>generic type, we cannot initialize it withnull.Currently, it is difficult to debug because there is no displayName for Provider, so the displayName is specified using the
contextNameprop.Since the type declaration of Context is as follows, when reading the Context with
useContext, it is inferred asContextValuesType | undefined.However, if there are no values received as props within the Provider,
nullis returned. If props exist, the received props are returned.Therefore, when reading
useContext,ContextValuesType | nullis actually returned, but the type system infersContextValuesType | undefined.To solve this complex and tangled type problem, the type of context was unified to
ContextValuesType | nullso that onlynullcan be handled.Since the type of
defaultContextValuesis<ContextValuesType extends object> | undefined,nullcannot be provided, so there is no need to handle the case ofnull.Checklist
yarn run fixto format and lint the code and docs?yarn run test:coverageto make sure there is no uncovered line?