Skip to content

Commit

Permalink
fix(*): remove unnecessary devDeps(react-dom, @types/react-dom) (#1180)
Browse files Browse the repository at this point in the history
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
  • Loading branch information
manudeli authored Aug 3, 2024
1 parent 0595002 commit 1db5fde
Show file tree
Hide file tree
Showing 10 changed files with 23 additions and 56 deletions.
10 changes: 10 additions & 0 deletions .changeset/calm-walls-develop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"@suspensive/cache": patch
"@suspensive/jotai": patch
"@suspensive/react-image": patch
"@suspensive/react-query-4": patch
"@suspensive/react-query-5": patch
"@suspensive/react-query": patch
---

fix(*): remove unnecessary devDeps(react-dom, @types/react-dom)
7 changes: 6 additions & 1 deletion .changeset/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,12 @@
"@suspensive/react-query-5"
]
],
"ignore": ["@suspensive/next-streaming-react-query", "@suspensive/visualization", "@suspensive/suspensive.org"],
"ignore": [
"@suspensive/next-streaming-react-query",
"@suspensive/visualization",
"@suspensive/suspensive.org",
"@suspensive/react-native-playground"
],
"linked": [],
"access": "restricted",
"baseBranch": "main",
Expand Down
2 changes: 1 addition & 1 deletion knip.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://unpkg.com/knip@5/schema.json",
"ignoreWorkspaces": ["websites/**", "examples/**"],
"ignoreDependencies": ["coauthors", "react-dom", "@types/react-dom", "@suspensive/utils"],
"ignoreDependencies": ["coauthors", "@suspensive/utils"],
"workspaces": {
".": {
"ignore": ["packlint.config.mjs"]
Expand Down
4 changes: 1 addition & 3 deletions packages/cache/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,7 @@
"@suspensive/tsconfig": "workspace:*",
"@suspensive/tsup": "workspace:*",
"@types/react": "^18.3.3",
"@types/react-dom": "^18.3.0",
"react": "^18.3.1",
"react-dom": "^18.3.1"
"react": "^18.3.1"
},
"peerDependencies": {
"react": "^18"
Expand Down
4 changes: 1 addition & 3 deletions packages/jotai/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,8 @@
"@suspensive/tsconfig": "workspace:*",
"@suspensive/tsup": "workspace:*",
"@types/react": "^18.3.3",
"@types/react-dom": "^18.3.0",
"jotai": "^2.8.4",
"react": "^18.3.1",
"react-dom": "^18.3.1"
"react": "^18.3.1"
},
"peerDependencies": {
"jotai": "^2",
Expand Down
4 changes: 1 addition & 3 deletions packages/react-image/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,7 @@
"@suspensive/tsconfig": "workspace:*",
"@suspensive/tsup": "workspace:*",
"@types/react": "^18.3.3",
"@types/react-dom": "^18.3.0",
"react": "^18.3.1",
"react-dom": "^18.3.1"
"react": "^18.3.1"
},
"peerDependencies": {
"react": "^18"
Expand Down
4 changes: 1 addition & 3 deletions packages/react-query-4/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,7 @@
"@suspensive/tsup": "workspace:*",
"@tanstack/react-query": "^4.36.1",
"@types/react": "^18.3.3",
"@types/react-dom": "^18.3.0",
"react": "^18.3.1",
"react-dom": "^18.3.1"
"react": "^18.3.1"
},
"peerDependencies": {
"@suspensive/react": "workspace:^2.12.0",
Expand Down
4 changes: 1 addition & 3 deletions packages/react-query-5/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,7 @@
"@suspensive/tsup": "workspace:*",
"@tanstack/react-query": "^5.51.16",
"@types/react": "^18.3.3",
"@types/react-dom": "^18.3.0",
"react": "^18.3.1",
"react-dom": "^18.3.1"
"react": "^18.3.1"
},
"peerDependencies": {
"@suspensive/react": "workspace:^2.12.0",
Expand Down
4 changes: 1 addition & 3 deletions packages/react-query/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,7 @@
"@suspensive/tsup": "workspace:*",
"@tanstack/react-query": "^4.36.1",
"@types/react": "^18.3.3",
"@types/react-dom": "^18.3.0",
"react": "^18.3.1",
"react-dom": "^18.3.1"
"react": "^18.3.1"
},
"peerDependencies": {
"@suspensive/react": "workspace:^2.12.0",
Expand Down
36 changes: 0 additions & 36 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1db5fde

Please sign in to comment.