fix(suspensive.org): add defense code for github contributors fetching #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@saul-atomrigs is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
CodSpeed Performance ReportMerging #1054 will create unknown performance changesComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1054 +/- ##
=======================================
Coverage 84.09% 84.09%
=======================================
Files 49 49
Lines 547 547
Branches 118 118
=======================================
Hits 460 460
Misses 82 82
Partials 5 5
|
manudeli
requested changes
Jul 8, 2024
Comment on lines
44
to
56
| if (Array.isArray(data) && data.length) { | ||
| const filteredContributors = data.filter((contributor) => { | ||
| const login = contributor.author.login | ||
| return !['github-actions[bot]', 'dependabot[bot]', 'renovate[bot]'].includes(login) | ||
| }) | ||
| setResult({ | ||
| data: filteredContributors, | ||
| error: undefined, | ||
| isError: false, | ||
| isLoading: false, | ||
| isSuccess: true, | ||
| }) | ||
| } |
There was a problem hiding this comment.
Even if the data is not an array or the length is 0, the fetch success status must be expressed as state. Please modify isSuccess to be true so that the correct server status state can be displayed even if the length of the data is 0 or there is no data when the fetch is successful.
There was a problem hiding this comment.
thank you, I've just pushed the change
It will keep isSuccess true for all 200 OK, even though the response data is empty or non-array
plus, I refactored the code for better exception messages
…data or other than array
manudeli
approved these changes
Jul 8, 2024
manudeli
pushed a commit
that referenced
this pull request
Aug 3, 2024
#1054) # Overview <!-- A clear and concise description of what this pr is about. --> Issue: #1051 I was able to reproduce the bug only by the time this issue was posted. Afterwards, I tried clearing the cache, browsing in secret mode, and even in another macbook (which never visited the page before) and in several browsers (chrome, safari, opera, edge), I couldn't reproduce the bug again... for now I added some defense code to where the error log pointed:  I'll keep an eye on this issue. ## PR Checklist - [✅] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests.
manudeli
pushed a commit
that referenced
this pull request
Aug 3, 2024
#1054) # Overview <!-- A clear and concise description of what this pr is about. --> Issue: #1051 I was able to reproduce the bug only by the time this issue was posted. Afterwards, I tried clearing the cache, browsing in secret mode, and even in another macbook (which never visited the page before) and in several browsers (chrome, safari, opera, edge), I couldn't reproduce the bug again... for now I added some defense code to where the error log pointed:  I'll keep an eye on this issue. ## PR Checklist - [✅] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests.
manudeli
pushed a commit
that referenced
this pull request
Aug 3, 2024
#1054) # Overview <!-- A clear and concise description of what this pr is about. --> Issue: #1051 I was able to reproduce the bug only by the time this issue was posted. Afterwards, I tried clearing the cache, browsing in secret mode, and even in another macbook (which never visited the page before) and in several browsers (chrome, safari, opera, edge), I couldn't reproduce the bug again... for now I added some defense code to where the error log pointed:  I'll keep an eye on this issue. ## PR Checklist - [✅] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests.
manudeli
pushed a commit
that referenced
this pull request
Aug 3, 2024
#1054) # Overview <!-- A clear and concise description of what this pr is about. --> Issue: #1051 I was able to reproduce the bug only by the time this issue was posted. Afterwards, I tried clearing the cache, browsing in secret mode, and even in another macbook (which never visited the page before) and in several browsers (chrome, safari, opera, edge), I couldn't reproduce the bug again... for now I added some defense code to where the error log pointed:  I'll keep an eye on this issue. ## PR Checklist - [✅] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Issue: #1051
I was able to reproduce the bug only by the time this issue was posted. Afterwards, I tried clearing the cache, browsing in secret mode, and even in another macbook (which never visited the page before) and in several browsers (chrome, safari, opera, edge), I couldn't reproduce the bug again... for now I added some defense code to where the error log pointed:
I'll keep an eye on this issue.
PR Checklist