feat(react): improve ClientOnly by useSyncExternalStore #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 33e39b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
manudeli
force-pushed
the
feat/improve-client-only
branch
from
48a0180 to
ecfd946
Compare
Co-authored-by: Dominik Dorfmeister <1021430+TkDodo@users.noreply.github.com> Co-authored-by: SeongMin Kim <86355699+Collection50@users.noreply.github.com> Co-authored-by: GwanSik Kim <39869096+gwansikk@users.noreply.github.com>
manudeli
force-pushed
the
feat/improve-client-only
branch
from
ecfd946 to
a041598
Compare
CodSpeed Performance ReportMerging #1105 will create unknown performance changesComparing Summary
|
manudeli
commented
Jul 18, 2024
There was a problem hiding this comment.
@TkDodo @Collection50 @gwansikk Could you review this please?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1105 +/- ##
==========================================
- Coverage 82.10% 82.08% -0.03%
==========================================
Files 66 66
Lines 721 720 -1
Branches 149 148 -1
==========================================
- Hits 592 591 -1
Misses 120 120
Partials 9 9
|
manudeli
pushed a commit
that referenced
this pull request
Jul 19, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/react@2.9.0 ### Minor Changes - [#1105](#1105) [`f9fb719`](f9fb719) Thanks [@manudeli](https://github.com/manudeli)! - feat(react): improve ClientOnly by useSyncExternalStore ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/cache@0.2.2 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/jotai@0.0.3 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/react-await@0.2.2 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/react-image@0.0.17 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/react-query@2.9.0 ### Patch Changes - Updated dependencies \[[`f9fb719`](f9fb719)]: - @suspensive/react@2.9.0 - @suspensive/react-query-4@2.9.0 - @suspensive/react-query-5@2.9.0 - @suspensive/utils@2.9.0 ## @suspensive/react-query-4@2.9.0 ### Patch Changes - Updated dependencies \[[`f9fb719`](f9fb719)]: - @suspensive/react@2.9.0 - @suspensive/utils@2.9.0 ## @suspensive/react-query-5@2.9.0 ### Patch Changes - Updated dependencies \[[`f9fb719`](f9fb719)]: - @suspensive/react@2.9.0 - @suspensive/utils@2.9.0 ## @suspensive/utils@2.9.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manudeli
added a commit
that referenced
this pull request
Aug 3, 2024
Idead by @TkDodo 🙇 close #528 # Overview <!-- A clear and concise description of what this pr is about. --> ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. --------- Co-authored-by: Dominik Dorfmeister <1021430+TkDodo@users.noreply.github.com> Co-authored-by: SeongMin Kim <86355699+Collection50@users.noreply.github.com> Co-authored-by: GwanSik Kim <39869096+gwansikk@users.noreply.github.com>
manudeli
added a commit
that referenced
this pull request
Aug 3, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/react@2.9.0 ### Minor Changes - [#1105](#1105) [`f9fb719`](f9fb719) Thanks [@manudeli](https://github.com/manudeli)! - feat(react): improve ClientOnly by useSyncExternalStore ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/cache@0.2.2 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/jotai@0.0.3 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/react-await@0.2.2 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/react-image@0.0.17 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/react-query@2.9.0 ### Patch Changes - Updated dependencies \[[`f9fb719`](f9fb719)]: - @suspensive/react@2.9.0 - @suspensive/react-query-4@2.9.0 - @suspensive/react-query-5@2.9.0 - @suspensive/utils@2.9.0 ## @suspensive/react-query-4@2.9.0 ### Patch Changes - Updated dependencies \[[`f9fb719`](f9fb719)]: - @suspensive/react@2.9.0 - @suspensive/utils@2.9.0 ## @suspensive/react-query-5@2.9.0 ### Patch Changes - Updated dependencies \[[`f9fb719`](f9fb719)]: - @suspensive/react@2.9.0 - @suspensive/utils@2.9.0 ## @suspensive/utils@2.9.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manudeli
added a commit
that referenced
this pull request
Aug 3, 2024
Idead by @TkDodo 🙇 close #528 # Overview <!-- A clear and concise description of what this pr is about. --> ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. ---------
manudeli
added a commit
that referenced
this pull request
Aug 3, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/react@2.9.0 ### Minor Changes - [#1105](#1105) [`f9fb719`](f9fb719) Thanks [@manudeli](https://github.com/manudeli)! - feat(react): improve ClientOnly by useSyncExternalStore ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/cache@0.2.2 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/jotai@0.0.3 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/react-await@0.2.2 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/react-image@0.0.17 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/react-query@2.9.0 ### Patch Changes - Updated dependencies \[[`f9fb719`](f9fb719)]: - @suspensive/react@2.9.0 - @suspensive/react-query-4@2.9.0 - @suspensive/react-query-5@2.9.0 - @suspensive/utils@2.9.0 ## @suspensive/react-query-4@2.9.0 ### Patch Changes - Updated dependencies \[[`f9fb719`](f9fb719)]: - @suspensive/react@2.9.0 - @suspensive/utils@2.9.0 ## @suspensive/react-query-5@2.9.0 ### Patch Changes - Updated dependencies \[[`f9fb719`](f9fb719)]: - @suspensive/react@2.9.0 - @suspensive/utils@2.9.0 ## @suspensive/utils@2.9.0
manudeli
added a commit
that referenced
this pull request
Aug 3, 2024
Idead by @TkDodo 🙇 close #528 # Overview <!-- A clear and concise description of what this pr is about. --> ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. --------- Co-authored-by: Dominik Dorfmeister <1021430+TkDodo@users.noreply.github.com> Co-authored-by: SeongMin Kim <86355699+Collection50@users.noreply.github.com> Co-authored-by: GwanSik Kim <39869096+gwansikk@users.noreply.github.com>
manudeli
added a commit
that referenced
this pull request
Aug 3, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/react@2.9.0 ### Minor Changes - [#1105](#1105) [`f9fb719`](f9fb719) Thanks [@manudeli](https://github.com/manudeli)! - feat(react): improve ClientOnly by useSyncExternalStore ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/cache@0.2.2 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/jotai@0.0.3 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/react-await@0.2.2 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/react-image@0.0.17 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/react-query@2.9.0 ### Patch Changes - Updated dependencies \[[`f9fb719`](f9fb719)]: - @suspensive/react@2.9.0 - @suspensive/react-query-4@2.9.0 - @suspensive/react-query-5@2.9.0 - @suspensive/utils@2.9.0 ## @suspensive/react-query-4@2.9.0 ### Patch Changes - Updated dependencies \[[`f9fb719`](f9fb719)]: - @suspensive/react@2.9.0 - @suspensive/utils@2.9.0 ## @suspensive/react-query-5@2.9.0 ### Patch Changes - Updated dependencies \[[`f9fb719`](f9fb719)]: - @suspensive/react@2.9.0 - @suspensive/utils@2.9.0 ## @suspensive/utils@2.9.0
manudeli
added a commit
that referenced
this pull request
Aug 3, 2024
Idead by @TkDodo 🙇 close #528 # Overview <!-- A clear and concise description of what this pr is about. --> ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. --------- Co-authored-by: Dominik Dorfmeister <1021430+TkDodo@users.noreply.github.com> Co-authored-by: SeongMin Kim <86355699+Collection50@users.noreply.github.com> Co-authored-by: GwanSik Kim <39869096+gwansikk@users.noreply.github.com>
manudeli
added a commit
that referenced
this pull request
Aug 3, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/react@2.9.0 ### Minor Changes - [#1105](#1105) [`f9fb719`](f9fb719) Thanks [@manudeli](https://github.com/manudeli)! - feat(react): improve ClientOnly by useSyncExternalStore ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/cache@0.2.2 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/jotai@0.0.3 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/react-await@0.2.2 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/react-image@0.0.17 ### Patch Changes - Updated dependencies \[]: - @suspensive/utils@2.9.0 ## @suspensive/react-query@2.9.0 ### Patch Changes - Updated dependencies \[[`f9fb719`](f9fb719)]: - @suspensive/react@2.9.0 - @suspensive/react-query-4@2.9.0 - @suspensive/react-query-5@2.9.0 - @suspensive/utils@2.9.0 ## @suspensive/react-query-4@2.9.0 ### Patch Changes - Updated dependencies \[[`f9fb719`](f9fb719)]: - @suspensive/react@2.9.0 - @suspensive/utils@2.9.0 ## @suspensive/react-query-5@2.9.0 ### Patch Changes - Updated dependencies \[[`f9fb719`](f9fb719)]: - @suspensive/react@2.9.0 - @suspensive/utils@2.9.0 ## @suspensive/utils@2.9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idead by @TkDodo 🙇
close #528
Overview
PR Checklist