Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-await): remove react-await package #1114

Merged
merged 1 commit into from
Jul 19, 2024
Merged

feat(react-await): remove react-await package #1114

merged 1 commit into from
Jul 19, 2024

Conversation

SEOKKAMONI
Copy link
Contributor

@SEOKKAMONI SEOKKAMONI commented Jul 19, 2024

Overview

close #1104

  • remove react-await package

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@SEOKKAMONI SEOKKAMONI requested a review from manudeli as a code owner July 19, 2024 13:51
Copy link

changeset-bot bot commented Jul 19, 2024

⚠️ No Changeset found

Latest commit: d0cb44b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 2:24pm
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 2:24pm
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 2:24pm

Copy link

vercel bot commented Jul 19, 2024

@SEOKKAMONI is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codspeed-hq bot commented Jul 19, 2024

CodSpeed Performance Report

Merging #1114 will create unknown performance changes

Comparing SEOKKAMONI:feat/remove-react-await (d0cb44b) with main (86a4640)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.45%. Comparing base (86a4640) to head (d0cb44b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1114      +/-   ##
==========================================
- Coverage   82.08%   79.45%   -2.63%     
==========================================
  Files          66       59       -7     
  Lines         720      628      -92     
  Branches      149      127      -22     
==========================================
- Hits          591      499      -92     
  Misses        120      120              
  Partials        9        9              
Components Coverage Δ
@suspensive/utils 47.16% <ø> (ø)
@suspensive/react 96.88% <ø> (ø)
@suspensive/react-query 71.96% <ø> (ø)
@suspensive/react-query-4 0.00% <ø> (ø)
@suspensive/react-query-5 0.00% <ø> (ø)
@suspensive/jotai 0.00% <ø> (ø)
@suspensive/cache 98.16% <ø> (ø)
@suspensive/react-image 80.39% <ø> (ø)

Copy link
Member

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@manudeli manudeli merged commit a1882b8 into toss:main Jul 19, 2024
14 checks passed
manudeli pushed a commit that referenced this pull request Aug 3, 2024
# Overview
close #1104

- remove react-await package
<!--
    A clear and concise description of what this pr is about.
 -->

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli pushed a commit that referenced this pull request Aug 3, 2024
# Overview
close #1104

- remove react-await package
<!--
    A clear and concise description of what this pr is about.
 -->

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli pushed a commit that referenced this pull request Aug 3, 2024
# Overview
close #1104

- remove react-await package
<!--
    A clear and concise description of what this pr is about.
 -->

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli pushed a commit that referenced this pull request Aug 3, 2024
# Overview
close #1104

- remove react-await package
<!--
    A clear and concise description of what this pr is about.
 -->

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Remove react-await to focus @suspensive/cache
3 participants