Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(suspensive.org): update tanstack query compatibility doc #1117

Merged
merged 7 commits into from
Jul 22, 2024

Conversation

gwansikk
Copy link
Collaborator

Overview

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@gwansikk gwansikk self-assigned this Jul 20, 2024
@gwansikk gwansikk linked an issue Jul 20, 2024 that may be closed by this pull request
Copy link

vercel bot commented Jul 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 1:03pm
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 1:03pm
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 1:03pm

Copy link

changeset-bot bot commented Jul 20, 2024

⚠️ No Changeset found

Latest commit: 81c5fdc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codspeed-hq bot commented Jul 20, 2024

CodSpeed Performance Report

Merging #1117 will create unknown performance changes

Comparing docs/feat/update-status-table (81c5fdc) with main (7b8a4c9)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.45%. Comparing base (7b8a4c9) to head (81c5fdc).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1117   +/-   ##
=======================================
  Coverage   79.45%   79.45%           
=======================================
  Files          59       59           
  Lines         628      628           
  Branches      127      127           
=======================================
  Hits          499      499           
  Misses        120      120           
  Partials        9        9           
Components Coverage Δ
@suspensive/utils 47.16% <ø> (ø)
@suspensive/react 96.88% <ø> (ø)
@suspensive/react-query 71.96% <ø> (ø)
@suspensive/react-query-4 0.00% <ø> (ø)
@suspensive/react-query-5 0.00% <ø> (ø)
@suspensive/jotai 0.00% <ø> (ø)
@suspensive/cache 98.16% <ø> (ø)
@suspensive/react-image 80.39% <ø> (ø)

Copy link
Member

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, more intuitivity is required. "version" is not proper word to differ @suspensive/react-query-4, @suspensive/react-query-5

Copy link
Member

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Much better!

@manudeli manudeli merged commit ec92987 into main Jul 22, 2024
17 checks passed
@manudeli manudeli deleted the docs/feat/update-status-table branch July 22, 2024 15:59
manudeli added a commit that referenced this pull request Aug 3, 2024
# Overview

- Documentation update for #1100
- Improved the clarity of the "tanstack query compatibility" doc

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
manudeli pushed a commit that referenced this pull request Aug 3, 2024
# Overview

- Documentation update for #1100
- Improved the clarity of the "tanstack query compatibility" doc

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------
manudeli added a commit that referenced this pull request Aug 3, 2024
# Overview

- Documentation update for #1100
- Improved the clarity of the "tanstack query compatibility" doc

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
manudeli added a commit that referenced this pull request Aug 3, 2024
# Overview

- Documentation update for #1100
- Improved the clarity of the "tanstack query compatibility" doc

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Docs for srq status as table
3 participants