docs(suspensive.org): add _document.tsx to include Sandpack CSS #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Size Change: 0 B Total Size: 86.6 kB ℹ️ View Unchanged
|
CodSpeed Performance ReportMerging #1145 will create unknown performance changesComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1145 +/- ##
=======================================
Coverage 75.25% 75.25%
=======================================
Files 62 62
Lines 594 594
Branches 116 117 +1
=======================================
Hits 447 447
Misses 137 137
Partials 10 10
|
Bundle sizes [visualization]Compared against 5008ad3 No significant changes found |
manudeli
added a commit
that referenced
this pull request
Aug 3, 2024
# Overview
<!--
A clear and concise description of what this pr is about.
-->
### [AS-IS]
Page appears broken when accessed because Sandpack's styles are not
being injected.
https://github.com/user-attachments/assets/42053df5-1608-4c2d-ab0d-e2a06fa974d4
<img width="838" alt="스크린샷 2024-07-26 오후 4 39 41"
src="https://github.com/user-attachments/assets/866c7486-aea6-4803-b6f1-214187997f8a">
### [TO-BE]
Resolve this by injecting Sandpack CSS into _document.tsx. [Sandpack
Document](https://sandpack.codesandbox.io/docs/guides/ssr#nextjs)
https://github.com/user-attachments/assets/45166635-77dd-46d6-acc5-49da580a57f6
<img width="838" alt="스크린샷 2024-07-26 오후 4 39 55"
src="https://github.com/user-attachments/assets/d123b5da-7252-45e0-a41e-c906f70cfff1">
## PR Checklist
- [x] I did below actions if need
1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
manudeli
pushed a commit
that referenced
this pull request
Aug 3, 2024
# Overview
<!--
A clear and concise description of what this pr is about.
-->
### [AS-IS]
Page appears broken when accessed because Sandpack's styles are not
being injected.
https://github.com/user-attachments/assets/42053df5-1608-4c2d-ab0d-e2a06fa974d4
<img width="838" alt="스크린샷 2024-07-26 오후 4 39 41"
src="https://github.com/user-attachments/assets/866c7486-aea6-4803-b6f1-214187997f8a">
### [TO-BE]
Resolve this by injecting Sandpack CSS into _document.tsx. [Sandpack
Document](https://sandpack.codesandbox.io/docs/guides/ssr#nextjs)
https://github.com/user-attachments/assets/45166635-77dd-46d6-acc5-49da580a57f6
<img width="838" alt="스크린샷 2024-07-26 오후 4 39 55"
src="https://github.com/user-attachments/assets/d123b5da-7252-45e0-a41e-c906f70cfff1">
## PR Checklist
- [x] I did below actions if need
1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli
added a commit
that referenced
this pull request
Aug 3, 2024
# Overview
<!--
A clear and concise description of what this pr is about.
-->
### [AS-IS]
Page appears broken when accessed because Sandpack's styles are not
being injected.
https://github.com/user-attachments/assets/42053df5-1608-4c2d-ab0d-e2a06fa974d4
<img width="838" alt="스크린샷 2024-07-26 오후 4 39 41"
src="https://github.com/user-attachments/assets/866c7486-aea6-4803-b6f1-214187997f8a">
### [TO-BE]
Resolve this by injecting Sandpack CSS into _document.tsx. [Sandpack
Document](https://sandpack.codesandbox.io/docs/guides/ssr#nextjs)
https://github.com/user-attachments/assets/45166635-77dd-46d6-acc5-49da580a57f6
<img width="838" alt="스크린샷 2024-07-26 오후 4 39 55"
src="https://github.com/user-attachments/assets/d123b5da-7252-45e0-a41e-c906f70cfff1">
## PR Checklist
- [x] I did below actions if need
1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
manudeli
added a commit
that referenced
this pull request
Aug 3, 2024
# Overview
<!--
A clear and concise description of what this pr is about.
-->
### [AS-IS]
Page appears broken when accessed because Sandpack's styles are not
being injected.
https://github.com/user-attachments/assets/42053df5-1608-4c2d-ab0d-e2a06fa974d4
<img width="838" alt="스크린샷 2024-07-26 오후 4 39 41"
src="https://github.com/user-attachments/assets/866c7486-aea6-4803-b6f1-214187997f8a">
### [TO-BE]
Resolve this by injecting Sandpack CSS into _document.tsx. [Sandpack
Document](https://sandpack.codesandbox.io/docs/guides/ssr#nextjs)
https://github.com/user-attachments/assets/45166635-77dd-46d6-acc5-49da580a57f6
<img width="838" alt="스크린샷 2024-07-26 오후 4 39 55"
src="https://github.com/user-attachments/assets/d123b5da-7252-45e0-a41e-c906f70cfff1">
## PR Checklist
- [x] I did below actions if need
1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[AS-IS]
Page appears broken when accessed because Sandpack's styles are not being injected.
2024-07-26.4.56.43.mov
[TO-BE]
Resolve this by injecting Sandpack CSS into _document.tsx. Sandpack Document
2024-07-26.4.56.03.mov
PR Checklist