Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): add ClientOnly #1162

Merged
merged 12 commits into from
Jul 30, 2024
Merged

feat(react): add ClientOnly #1162

merged 12 commits into from
Jul 30, 2024

Conversation

Collection50
Copy link
Contributor

Overview

Set public component <ClientOnly/>.

close #1158

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@Collection50 Collection50 requested a review from manudeli as a code owner July 30, 2024 04:01
Copy link

changeset-bot bot commented Jul 30, 2024

🦋 Changeset detected

Latest commit: cf0dc81

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@suspensive/react Minor
@suspensive/cache Patch
@suspensive/react-query-4 Minor
@suspensive/react-query-5 Minor
@suspensive/react-query Minor
@suspensive/utils Minor
@suspensive/jotai Patch
@suspensive/react-image Patch
@suspensive/react-native Patch
@suspensive/react-native-playground Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 0:07am
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 0:07am
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 0:07am

Copy link

vercel bot commented Jul 30, 2024

@Collection50 is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codspeed-hq bot commented Jul 30, 2024

CodSpeed Performance Report

Merging #1162 will create unknown performance changes

Comparing Collection50:react/ClientOnly (cf0dc81) with main (53657b2)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.

Co-authored-by: GwanSik Kim <39869096+gwansikk@users.noreply.github.com>
Co-authored-by: 김석진(poki) <102217654+SEOKKAMONI@users.noreply.github.com>
Co-authored-by: Juhyeok Kang <23312485+kangju2000@users.noreply.github.com>
Co-authored-by: 김동희 <31029000+bigsaigon333@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.60%. Comparing base (53657b2) to head (a6fb1fe).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1162   +/-   ##
=======================================
  Coverage   77.60%   77.60%           
=======================================
  Files          62       62           
  Lines         594      594           
  Branches      117      116    -1     
=======================================
  Hits          461      461           
  Misses        123      123           
  Partials       10       10           
Components Coverage Δ
@suspensive/utils 47.16% <ø> (ø)
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-query 72.18% <ø> (ø)
@suspensive/react-query-4 0.00% <ø> (ø)
@suspensive/react-query-5 0.00% <ø> (ø)
@suspensive/jotai 0.00% <ø> (ø)
@suspensive/cache 98.23% <ø> (ø)
@suspensive/react-image 80.39% <ø> (ø)

@manudeli manudeli marked this pull request as draft July 30, 2024 12:00
@manudeli manudeli marked this pull request as ready for review July 30, 2024 12:01
@manudeli manudeli self-requested a review July 30, 2024 12:01
Copy link
Member

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Collection50 Thanks!

@gwansikk @kangju2000 @bigsaigon333 @SEOKKAMONI I added you as co-author too. Thanks for your dicussing to add this.

@manudeli
Copy link
Member

manudeli commented Jul 30, 2024

@Collection50 Thanks for raising this issue about ClientOnly and resolve yourself! It's great work! 🚀

@manudeli manudeli merged commit d29bf9f into toss:main Jul 30, 2024
16 checks passed
manudeli pushed a commit that referenced this pull request Jul 30, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @suspensive/react@2.11.0

### Minor Changes

- [#1162](#1162)
[`d29bf9f`](d29bf9f)
Thanks [@Collection50](https://github.com/Collection50)! - feat(react):
add ClientOnly

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/cache@0.3.1

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/jotai@0.0.9

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/react-image@0.0.23

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/react-native@0.0.1

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/react-query@2.11.0

### Patch Changes

- Updated dependencies
\[[`d29bf9f`](d29bf9f)]:
    -   @suspensive/react@2.11.0
    -   @suspensive/react-query-4@2.11.0
    -   @suspensive/react-query-5@2.11.0
    -   @suspensive/utils@2.11.0

## @suspensive/react-query-4@2.11.0

### Patch Changes

- Updated dependencies
\[[`d29bf9f`](d29bf9f)]:
    -   @suspensive/react@2.11.0
    -   @suspensive/utils@2.11.0

## @suspensive/react-query-5@2.11.0

### Patch Changes

- Updated dependencies
\[[`d29bf9f`](d29bf9f)]:
    -   @suspensive/react@2.11.0
    -   @suspensive/utils@2.11.0

## @suspensive/utils@2.11.0



## @suspensive/react-native-playground@1.0.1

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/react-native@0.0.1

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manudeli added a commit that referenced this pull request Aug 3, 2024
# Overview

Set public component `<ClientOnly/>`.

close #1158 

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
Co-authored-by: GwanSik Kim <39869096+gwansikk@users.noreply.github.com>
Co-authored-by: 김석진(poki) <102217654+SEOKKAMONI@users.noreply.github.com>
Co-authored-by: Juhyeok Kang <23312485+kangju2000@users.noreply.github.com>
Co-authored-by: 김동희 <31029000+bigsaigon333@users.noreply.github.com>
manudeli added a commit that referenced this pull request Aug 3, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @suspensive/react@2.11.0

### Minor Changes

- [#1162](#1162)
[`d29bf9f`](d29bf9f)
Thanks [@Collection50](https://github.com/Collection50)! - feat(react):
add ClientOnly

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/cache@0.3.1

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/jotai@0.0.9

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/react-image@0.0.23

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/react-native@0.0.1

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/react-query@2.11.0

### Patch Changes

- Updated dependencies
\[[`d29bf9f`](d29bf9f)]:
    -   @suspensive/react@2.11.0
    -   @suspensive/react-query-4@2.11.0
    -   @suspensive/react-query-5@2.11.0
    -   @suspensive/utils@2.11.0

## @suspensive/react-query-4@2.11.0

### Patch Changes

- Updated dependencies
\[[`d29bf9f`](d29bf9f)]:
    -   @suspensive/react@2.11.0
    -   @suspensive/utils@2.11.0

## @suspensive/react-query-5@2.11.0

### Patch Changes

- Updated dependencies
\[[`d29bf9f`](d29bf9f)]:
    -   @suspensive/react@2.11.0
    -   @suspensive/utils@2.11.0

## @suspensive/utils@2.11.0



## @suspensive/react-native-playground@1.0.1

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/react-native@0.0.1

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manudeli pushed a commit that referenced this pull request Aug 3, 2024
# Overview

Set public component `<ClientOnly/>`.

close #1158 

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------
manudeli added a commit that referenced this pull request Aug 3, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @suspensive/react@2.11.0

### Minor Changes

- [#1162](#1162)
[`d29bf9f`](d29bf9f)
Thanks [@Collection50](https://github.com/Collection50)! - feat(react):
add ClientOnly

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/cache@0.3.1

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/jotai@0.0.9

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/react-image@0.0.23

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/react-native@0.0.1

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/react-query@2.11.0

### Patch Changes

- Updated dependencies
\[[`d29bf9f`](d29bf9f)]:
    -   @suspensive/react@2.11.0
    -   @suspensive/react-query-4@2.11.0
    -   @suspensive/react-query-5@2.11.0
    -   @suspensive/utils@2.11.0

## @suspensive/react-query-4@2.11.0

### Patch Changes

- Updated dependencies
\[[`d29bf9f`](d29bf9f)]:
    -   @suspensive/react@2.11.0
    -   @suspensive/utils@2.11.0

## @suspensive/react-query-5@2.11.0

### Patch Changes

- Updated dependencies
\[[`d29bf9f`](d29bf9f)]:
    -   @suspensive/react@2.11.0
    -   @suspensive/utils@2.11.0

## @suspensive/utils@2.11.0



## @suspensive/react-native-playground@1.0.1

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/react-native@0.0.1
manudeli added a commit that referenced this pull request Aug 3, 2024
# Overview

Set public component `<ClientOnly/>`.

close #1158 

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
Co-authored-by: GwanSik Kim <39869096+gwansikk@users.noreply.github.com>
Co-authored-by: 김석진(poki) <102217654+SEOKKAMONI@users.noreply.github.com>
Co-authored-by: Juhyeok Kang <23312485+kangju2000@users.noreply.github.com>
Co-authored-by: 김동희 <31029000+bigsaigon333@users.noreply.github.com>
manudeli added a commit that referenced this pull request Aug 3, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @suspensive/react@2.11.0

### Minor Changes

- [#1162](#1162)
[`d29bf9f`](d29bf9f)
Thanks [@Collection50](https://github.com/Collection50)! - feat(react):
add ClientOnly

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/cache@0.3.1

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/jotai@0.0.9

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/react-image@0.0.23

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/react-native@0.0.1

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/react-query@2.11.0

### Patch Changes

- Updated dependencies
\[[`d29bf9f`](d29bf9f)]:
    -   @suspensive/react@2.11.0
    -   @suspensive/react-query-4@2.11.0
    -   @suspensive/react-query-5@2.11.0
    -   @suspensive/utils@2.11.0

## @suspensive/react-query-4@2.11.0

### Patch Changes

- Updated dependencies
\[[`d29bf9f`](d29bf9f)]:
    -   @suspensive/react@2.11.0
    -   @suspensive/utils@2.11.0

## @suspensive/react-query-5@2.11.0

### Patch Changes

- Updated dependencies
\[[`d29bf9f`](d29bf9f)]:
    -   @suspensive/react@2.11.0
    -   @suspensive/utils@2.11.0

## @suspensive/utils@2.11.0



## @suspensive/react-native-playground@1.0.1

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/react-native@0.0.1
manudeli added a commit that referenced this pull request Aug 3, 2024
# Overview

Set public component `<ClientOnly/>`.

close #1158 

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
Co-authored-by: GwanSik Kim <39869096+gwansikk@users.noreply.github.com>
Co-authored-by: 김석진(poki) <102217654+SEOKKAMONI@users.noreply.github.com>
Co-authored-by: Juhyeok Kang <23312485+kangju2000@users.noreply.github.com>
Co-authored-by: 김동희 <31029000+bigsaigon333@users.noreply.github.com>
manudeli added a commit that referenced this pull request Aug 3, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @suspensive/react@2.11.0

### Minor Changes

- [#1162](#1162)
[`d29bf9f`](d29bf9f)
Thanks [@Collection50](https://github.com/Collection50)! - feat(react):
add ClientOnly

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/cache@0.3.1

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/jotai@0.0.9

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/react-image@0.0.23

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/react-native@0.0.1

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/utils@2.11.0

## @suspensive/react-query@2.11.0

### Patch Changes

- Updated dependencies
\[[`d29bf9f`](d29bf9f)]:
    -   @suspensive/react@2.11.0
    -   @suspensive/react-query-4@2.11.0
    -   @suspensive/react-query-5@2.11.0
    -   @suspensive/utils@2.11.0

## @suspensive/react-query-4@2.11.0

### Patch Changes

- Updated dependencies
\[[`d29bf9f`](d29bf9f)]:
    -   @suspensive/react@2.11.0
    -   @suspensive/utils@2.11.0

## @suspensive/react-query-5@2.11.0

### Patch Changes

- Updated dependencies
\[[`d29bf9f`](d29bf9f)]:
    -   @suspensive/react@2.11.0
    -   @suspensive/utils@2.11.0

## @suspensive/utils@2.11.0



## @suspensive/react-native-playground@1.0.1

### Patch Changes

-   Updated dependencies \[]:
    -   @suspensive/react-native@0.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] new <ClienOnly/>
4 participants