Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(suspensive.org): add punctuation marks to a document #1168

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

SID12g
Copy link
Contributor

@SID12g SID12g commented Aug 1, 2024

Overview

I modified punctuation marks such as punctuation and space in Korean and English documents.

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@SID12g SID12g requested a review from manudeli as a code owner August 1, 2024 05:52
Copy link

changeset-bot bot commented Aug 1, 2024

⚠️ No Changeset found

Latest commit: 03431f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 1:02pm
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 1:02pm
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 1:02pm

Copy link

vercel bot commented Aug 1, 2024

@SID12g is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codspeed-hq bot commented Aug 1, 2024

CodSpeed Performance Report

Merging #1168 will create unknown performance changes

Comparing SID12g:docs/add-punctuation-marks (03431f3) with main (0eb7cfc)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.01%. Comparing base (0eb7cfc) to head (03431f3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1168   +/-   ##
=======================================
  Coverage   78.01%   78.01%           
=======================================
  Files          63       63           
  Lines         605      605           
  Branches      121      122    +1     
=======================================
  Hits          472      472           
  Misses        123      123           
  Partials       10       10           
Components Coverage Δ
@suspensive/utils 47.16% <ø> (ø)
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-query 72.18% <ø> (ø)
@suspensive/react-query-4 0.00% <ø> (ø)
@suspensive/react-query-5 0.00% <ø> (ø)
@suspensive/jotai 0.00% <ø> (ø)
@suspensive/cache 98.23% <ø> (ø)
@suspensive/react-image 80.39% <ø> (ø)

Copy link
Member

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@manudeli manudeli merged commit 16c051a into toss:main Aug 1, 2024
15 of 16 checks passed
manudeli added a commit that referenced this pull request Aug 3, 2024
# Overview

I modified punctuation marks such as punctuation and space in Korean and
English documents.

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
manudeli pushed a commit that referenced this pull request Aug 3, 2024
# Overview

I modified punctuation marks such as punctuation and space in Korean and
English documents.

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------
manudeli added a commit that referenced this pull request Aug 3, 2024
# Overview

I modified punctuation marks such as punctuation and space in Korean and
English documents.

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
manudeli added a commit that referenced this pull request Aug 3, 2024
# Overview

I modified punctuation marks such as punctuation and space in Korean and
English documents.

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
2-NOW pushed a commit to 2-NOW/suspensive that referenced this pull request Aug 16, 2024
# Overview

I modified punctuation marks such as punctuation and space in Korean and
English documents.

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants