-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): add <ClientOnly/>
internally
#964
Merged
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8233f4f
feat: implement component ClientOnly, and useIsClient hook
Collection50 e9ed50b
docs: add typo
Collection50 25bf926
test: tescode for ClientOnly
Collection50 0414ee5
docs: fix typo
Collection50 d003781
test: fix typo in test code
Collection50 337b875
Create thirty-panthers-flash.md
manudeli 68a04a7
Merge branch 'main' into ClientOnly
manudeli 4352b03
fix: add ClientOnly interface
Collection50 76a5003
fix: fix ClientOnly logic
Collection50 f63a253
fix: type error
Collection50 4b8d354
test: fix import path of useIsClient
Collection50 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@suspensive/react": patch | ||
--- | ||
|
||
fix(react): add `<ClienOnly/>` for clientOnly prop of `<Suspense/>` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
import { render, screen } from '@testing-library/react' | ||
import { useIsClient } from '../hooks/useIsClient' | ||
import { ClientOnly } from './ClientOnly' | ||
|
||
vi.mock('./useIsClient', () => ({ | ||
useIsClient: vi.fn(), | ||
})) | ||
|
||
afterEach(() => { | ||
vi.clearAllMocks() | ||
}) | ||
|
||
describe('<ClientOnly/>', () => { | ||
it('renders children when isClient is true', () => { | ||
useIsClient.mockReturnValue(true) | ||
|
||
render( | ||
<ClientOnly fallback={<div>Loading...</div>}> | ||
<div>Client Content</div> | ||
</ClientOnly> | ||
) | ||
|
||
expect(screen.getByText('Client Content')).toBeInTheDocument() | ||
expect(screen.queryByText('Loading...')).not.toBeInTheDocument() | ||
}) | ||
|
||
it('renders fallback when isClient is false', () => { | ||
useIsClient.mockReturnValue(false) | ||
|
||
render( | ||
<ClientOnly fallback={<div>Loading...</div>}> | ||
<div>Client Content</div> | ||
</ClientOnly> | ||
) | ||
|
||
expect(screen.getByText('Loading...')).toBeInTheDocument() | ||
expect(screen.queryByText('Client Content')).not.toBeInTheDocument() | ||
}) | ||
}) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cool test code! |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import type { ReactNode } from 'react' | ||
import { useIsClient } from '../hooks/useIsClient' | ||
|
||
interface ClientOnlyProps { | ||
children: ReactNode | ||
fallback?: ReactNode | ||
} | ||
|
||
export const ClientOnly = ({ children, fallback }: ClientOnlyProps) => <>{useIsClient() ? children : fallback}</> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍