Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sk.json #1592

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Update sk.json #1592

merged 1 commit into from
Nov 10, 2024

Conversation

OskarSidor
Copy link
Contributor

@OskarSidor OskarSidor commented Nov 10, 2024

Updated Slovak translation

Proposed Change

Updated translation of "fullDayEventText" and "untilText" in common section to better reflect their meaning on the card.
Additionally, in event section, "fullDayEventText" translation was also updated to improve clarity by avoiding use of different synonyms for word event in translations.

Related issues

N/A

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (build / ci etc.)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Summary by Sourcery

Bug Fixes:

  • Correct Slovak translations for 'fullDayEventText' and 'untilText' to improve clarity and consistency.

Updated Slovak translation
Copy link

sourcery-ai bot commented Nov 10, 2024

Reviewer's Guide by Sourcery

This PR updates the Slovak (sk.json) translation file to improve clarity and consistency in the translation of specific terms related to full-day events and time ranges. The changes focus on making the translations more accurate and maintaining consistent terminology throughout the file.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated common section translations for better clarity
  • Changed 'Všetky dni' (All days) to 'Celý deň' (Full day) for better accuracy
  • Updated 'Dokiaľ' to 'do' for a more natural translation of 'until'
src/localize/languages/sk.json
Improved consistency in event section terminology
  • Changed 'Text celodenného podujatia' to 'Text celodennej udalosti' to maintain consistent use of the word 'udalosti' (event) instead of 'podujatia'
src/localize/languages/sk.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OskarSidor - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@marksie1988 marksie1988 merged commit 22c2ca7 into totaldebug:beta Nov 10, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants