Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sonarr version URI #102

Merged
merged 2 commits into from
May 3, 2022
Merged

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented May 3, 2022

fix #101

@Archmonger Archmonger mentioned this pull request May 3, 2022
2 tasks
@Archmonger Archmonger marked this pull request as ready for review May 3, 2022 05:02
@sourcery-ai
Copy link

sourcery-ai bot commented May 3, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.01%.

Quality metrics Before After Change
Complexity 0.33 ⭐ 0.34 ⭐ 0.01 👎
Method Length 24.98 ⭐ 24.96 ⭐ -0.02 👍
Working memory 5.37 ⭐ 5.38 ⭐ 0.01 👎
Quality 90.74% 90.73% -0.01% 👎
Other metrics Before After Change
Lines 839 839 0
Changed files Quality Before Quality After Quality Change
pyarr/radarr.py 91.20% ⭐ 91.20% ⭐ 0.00%
pyarr/sonarr.py 90.17% ⭐ 90.13% ⭐ -0.04% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pyarr/sonarr.py SonarrAPI._series_json 4 ⭐ 80 🙂 12 😞 64.24% 🙂 Extract out complex expressions
pyarr/radarr.py RadarrAPI._movie_json 3 ⭐ 71 🙂 10 😞 70.21% 🙂 Extract out complex expressions
pyarr/sonarr.py SonarrAPI.add_series 0 ⭐ 43 ⭐ 11 😞 75.72% ⭐ Extract out complex expressions
pyarr/radarr.py RadarrAPI.get_queue 0 ⭐ 40 ⭐ 11 😞 76.21% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@marksie1988 marksie1988 merged commit 5377128 into totaldebug:master May 3, 2022
@Archmonger Archmonger deleted the add-ver-uri-param branch May 3, 2022 06:35
@marksie1988 marksie1988 added the type/bug Something isn't working label May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add V3 Sonarr API support
2 participants