-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Readarr support #84
Conversation
I think the idea of BaseAPI could get sticky as we expand to more than just Sonarr/Radarr. Not sure if I support the concept, would make scaling to different APIs awkward. If we're adding Readarr, Bazarr, Lidarr, and Prowlarr support it'd reduce complexity to have code duplication over a base construct. |
All of the ARR products are following the same API structure, all base endpoints are the same and are becoming more aligned over time. The amount of code having to be maintained will be significantly reduced by moving to a base API. |
Hey @Archmonger, Its been a long while and I've made a lot of changes, If you have some time I would appreciate your review on this one to ensure things are working as expected etc. Not all Readarr functionality is implemented however I have got the main things people will want working, the main things not implemented are the same as with the Sonarr & Radarr implementation so shouldn't be an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally don't use Readarr so I haven't done any testing on this PR.
This is purely a code review.
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 21.56%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Description
Add support for Readarr, This will also include creating a BaseAPI class that will take duplicated functions into a single file to reduce duplication across the package.
Related issues
Motivation and Context
How has this been tested
This is being tested in my lab during development
Types of changes
Checklist