Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor using Sourcery #90

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Nov 5, 2021

This PR uses Sourcery to automatically refactor our code to minimize memory usage and improve readablity.

@Archmonger Archmonger self-assigned this Nov 5, 2021
@Archmonger Archmonger added the P3 Low-priority issue that needs to be resolved label Nov 5, 2021
@Archmonger
Copy link
Contributor Author

Archmonger commented Nov 5, 2021

Also I recommend merging PRs using "Squash and Merge" so there is a sensible message in the commit logs.

@marksie1988
Copy link
Collaborator

Also I recommend merging PRs using "Squash and Merge" so there is a sensible message in the commit logs.

Yep I normally disable other merge types but forgot on this repo, I will update that now.

Also taken a look at sourcery and never heard of it but I like what it does and seems very efficient so will merge this.

@marksie1988 marksie1988 merged commit ace655f into totaldebug:master Nov 5, 2021
@Archmonger Archmonger deleted the sourcery-refactoring branch November 5, 2021 09:46
@Archmonger
Copy link
Contributor Author

Archmonger commented Nov 5, 2021

I definitely would recommend taking a look at using Sourcery as both an editor plugin and directly integrating it as a GH Repository App.

Here's an example of the kind of "quick metrics" you can get on each PR.

Quickly becoming one of my favorite new code suggestion/refactoring tool (RIP DeepCode 😢).

@marksie1988
Copy link
Collaborator

Oh nice,

I think I will look into this some more and get it implemented :) thanks for showing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low-priority issue that needs to be resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants