Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding Lidarr API #97

Merged
merged 4 commits into from
Mar 15, 2022
Merged

feat: Adding Lidarr API #97

merged 4 commits into from
Mar 15, 2022

Conversation

marksie1988
Copy link
Collaborator

Description

Adding support for the Lidarr API

Related issues

closes #81

Motivation and Context

Adds additional support for new arr APIs

How has this been tested

Most functions have been tested, however tests still need to be setup for this PR

Types of changes

  • Docs change / refactoring.
  • Non-breaking change (fix or feature that wouldn't cause existing functionality to change/break).
  • Breaking change (fix or feature that would cause existing functionality to change/break).

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes don't generate new warnings.
  • I have read the CONTRIBUTING document.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests pass.

@marksie1988 marksie1988 added the type/feature New feature or request label Mar 9, 2022
@marksie1988 marksie1988 marked this pull request as draft March 9, 2022 22:32
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 10, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.06%.

Quality metrics Before After Change
Complexity 0.83 ⭐ 0.88 ⭐ 0.05 👎
Method Length 27.60 ⭐ 27.52 ⭐ -0.08 👍
Working memory 6.29 🙂 6.27 🙂 -0.02 👍
Quality 85.83% 85.77% -0.06% 👎
Other metrics Before After Change
Lines 2297 2344 47
Changed files Quality Before Quality After Quality Change
pyarr/init.py 99.00% ⭐ 98.50% ⭐ -0.50% 👎
pyarr/base.py 92.26% ⭐ 92.35% ⭐ 0.09% 👍
pyarr/exceptions.py 98.00% ⭐ 97.50% ⭐ -0.50% 👎
pyarr/radarr.py 91.20% ⭐ 91.20% ⭐ 0.00%
pyarr/readarr.py 75.68% ⭐ 75.52% ⭐ -0.16% 👎
pyarr/request_handler.py 82.79% ⭐ 80.30% ⭐ -2.49% 👎
pyarr/sonarr.py 90.17% ⭐ 90.17% ⭐ 0.00%
sphinx-docs/conf.py 66.05% 🙂 66.30% 🙂 0.25% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pyarr/readarr.py ReadarrAPI._book_json 7 ⭐ 149 😞 15 😞 48.25% 😞 Try splitting into smaller methods. Extract out complex expressions
pyarr/readarr.py ReadarrAPI._author_json 6 ⭐ 100 🙂 13 😞 57.87% 🙂 Extract out complex expressions
pyarr/readarr.py ReadarrAPI.add_root_folder 1 ⭐ 60 ⭐ 17 ⛔ 63.92% 🙂 Extract out complex expressions
pyarr/sonarr.py SonarrAPI._series_json 4 ⭐ 80 🙂 12 😞 64.24% 🙂 Extract out complex expressions
pyarr/readarr.py ReadarrAPI.add_book 1 ⭐ 63 🙂 14 😞 66.82% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@marksie1988 marksie1988 marked this pull request as ready for review March 14, 2022 12:08
@marksie1988 marksie1988 merged commit 0b6097c into master Mar 15, 2022
@marksie1988 marksie1988 deleted the 81-add_lidarr_support branch June 28, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Lidarr support
1 participant