Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore global api functions #372

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Restore global api functions #372

merged 3 commits into from
Oct 11, 2023

Conversation

kpgalligan
Copy link
Collaborator

The api refactor cut the global functions that were added for tag convenience.

Reference: #371

@findjigar findjigar merged commit 96281ab into main Oct 11, 2023
2 checks passed
@findjigar findjigar deleted the kpg/restore_global_api branch October 11, 2023 17:01
@sproctor
Copy link

Restoring the global functions seems to have made them ambiguous.

Logger.d(tag = "MyTag") { "debug message" }

Now gives:

e: file:... Overload resolution ambiguity: 
public final fun d(tag: String, throwable: Throwable? = ..., message: () -> String): Unit defined in co.touchlab.kermit.Logger.Companion
public final inline fun d(throwable: Throwable? = ..., tag: String = ..., message: () -> String): Unit defined in co.touchlab.kermit.Logger.Companion

@SamC-Apadmi
Copy link

Is there a solution to this ambiguity problem? 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants