Enable KLib ABI validation #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
force-pushed
the
enable-klib-validation
branch
from
6c3bdca to
f51a77f
Compare
| } | ||
|
|
||
| rootProject.name = "kermit-root" |
There was a problem hiding this comment.
Is this needed? What is this added for?
There was a problem hiding this comment.
Yeah, there is a bug in BCV related to Kotlin/binary-compatibility-validator#261.
There was a problem hiding this comment.
Ooops, it still failed on CI, see https://github.com/touchlab/Kermit/actions/runs/11709073063/job/32612290197.
May have to revert this change until the issue has been fixed on BCV side.
KevinSchildhorn
approved these changes
Nov 6, 2024
KevinSchildhorn
added a commit
that referenced
this pull request
Nov 7, 2024
This reverts commit 4a0ea16.
KevinSchildhorn
added a commit
that referenced
this pull request
Nov 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Kotlin/binary-compatibility-validator?tab=readme-ov-file#experimental-klib-abi-validation-support