Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements #334

Merged
merged 7 commits into from
Nov 28, 2023
Merged

UI improvements #334

merged 7 commits into from
Nov 28, 2023

Conversation

stintel
Copy link
Collaborator

@stintel stintel commented Nov 17, 2023

A bunch of UI changes mostly to avoid inconsistencies in text alignment.

@stintel stintel changed the title Minor UI improvements UI improvements Nov 22, 2023
@stintel stintel force-pushed the fix/ui_improvements branch 2 times, most recently from 680366d to 4a70eb2 Compare November 22, 2023 17:58

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This way we're certain they're correctly set and don't have to worry
about it anywhere else we're touching labels.
The header feels a bit too close to the text label below it. Lower all
text labels by 10 px to fix this. Also remove alignment changes from
other parse of the code, to avoid running into weird misaligned labels.
The bezel on the final version of the ESP32-S3-Box-3 seems to cover the
edges of the display. Reduce the text label width and offset the
alignment to avoid the bezel covering the labels.
They will mostly appear during startup, when the middle line has
centered "Starting up (server) ...". Having them not aligned the same
looks weird.
The label sometimes showed "Connecting to WAS ..." when it shouldn't.
Clear the label and restore text alignment to left, to avoid the label
showing up when it shouldn't.
When mute is active during boot, we use ui_pr_err to inform the user
that unmute is required to continue. At this point, lbl_ln3 text is
center aligned, but lbl_ln4 text is left aligned.

As we want the error messages to draw attention, let's always center
align text in those 2 labels in ui_pr_err.
As we're center aligning text in lbl_lb4 in ui_pr_err, we need to make
sure we left align it again when writing responses from command
endpoint, WAS, or multinet. While at it, also always center align
lbl_ln5 text to avoid further UI inconsistencies down the road.
@stintel stintel force-pushed the fix/ui_improvements branch from 4a70eb2 to b1c2bc3 Compare November 23, 2023 12:15
@kristiankielhofner kristiankielhofner merged commit a5cd3ed into main Nov 28, 2023
15 checks passed
@kristiankielhofner kristiankielhofner deleted the fix/ui_improvements branch November 28, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants