Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pin-project-lite #115

Closed
davidpdrsn opened this issue Aug 5, 2021 · 2 comments · Fixed by #151
Closed

Migrate to pin-project-lite #115

davidpdrsn opened this issue Aug 5, 2021 · 2 comments · Fixed by #151
Labels
C-enhancement Category: A PR with an enhancement or a proposed on in an issue.
Milestone

Comments

@davidpdrsn
Copy link
Member

Tower recently migrated to pin-project-lite (tower-rs/tower#595) so it makes sense to do the same for tower-http. It should be a fairly mechanical operation. Off the top of my head tower-http isn't using any of pin-projects more advanced features.

@davidpdrsn davidpdrsn added C-enhancement Category: A PR with an enhancement or a proposed on in an issue. E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. labels Aug 5, 2021
@davidpdrsn davidpdrsn changed the title Migration to pin-project-lite Migrate to pin-project-lite Aug 5, 2021
@tesaguri
Copy link
Contributor

tesaguri commented Aug 5, 2021

Migrating compression::Body and dexompression::Body would be difficult because their inner enums have #[cfg(...)] attributes on its variants, which pin-project-lite does not support yet (taiki-e/pin-project-lite#3). There is a workaround (taiki-e/pin-project-lite#3 (comment)) like the one I originally used in #41, though it would introduce a huge macro.

@davidpdrsn davidpdrsn removed E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. labels Sep 18, 2021
@jplatte
Copy link
Collaborator

jplatte commented Oct 15, 2021

Working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: A PR with an enhancement or a proposed on in an issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants