Switch from pin-project to pin-project-lite #151
Conversation
There was a problem hiding this comment.
Thanks @jplatte. It looks good to me 😊
A merge/rebase of master should fix CI.
|
Just a small heads up I think I'll merge #156 before this, which might lead to some merge conflicts here. |
|
Rebased. Also had to switch the new |
tower-http/src/cors.rs
Outdated
| @@ -4,7 +4,7 @@ | |||
| //! | |||
| //! ``` | |||
| //! use http::{Request, Response, Method, header}; | |||
| //! use hyper::Body; | |||
| //! use hypefut: futureBody; | |||
There was a problem hiding this comment.
I guess this needs to be
| //! use hypefut: futureBody; | |
| //! use hyper::Body; |
There was a problem hiding this comment.
Looks like rust-analyzer used some outdated spans when doing updating uses of a field I renamed 😅
There was a problem hiding this comment.
huh, that seems like maybe something that deserves an upstream bug report?
Head branch was pushed to by a user without write access
|
@jplatte wanna fix the last round of conflicts? Then we can merge 🚀 |
|
Done. Also added a reference to the exhaustive match feature tracking issue to the first |
|
Thanks a lot for working on this! |
Fixes #115.
Contains a decent amount of duplicated code, most of which can be removed once rust-lang/rust#51085 is stable. It might be possible to reduce this duplication using a macro (but I'm not sure whether macros are allowed to take the place of entire match arms, rather than just patterns / expressions), if you want I'll look into that.