Allow users to control level of Tracing spans #124
Conversation
|
Whoops! Sorry—I've accidently closed this PR before I wrote my message. I also didn't meant to close it! Gimme a second as I write the message! |
|
(I'm putting on my "tracing contributor" hat on.) Anyways! I noticed that in #123, you mentioned that you're creating the TraceLayer::new_for_http()
.on_request(trace::DefaultOnRequest::new().level(Level::INFO))
.on_response(trace::DefaultOnResponse::new().level(Level::INFO))It seems to me that |
|
Oh, you're right! I was so focused on the Thank you! |
|
I've opened. I still think it would be nice to address this inconsistency. Will review tomorrow. |
|
Thanks for the review and also sorry for the delay! I'm on vacation. I'll take care of this at some point during the next weeks. |
|
No worries :) |
This doesn't make sense as-is, but I'm about to add an additional non-`Default` field to `DefaultMakeSpan`. It will no longer be possible to derive `Default` once that happens.
This is a minimally invasive fix for tower-rs#123. It's certainly not ideal, API-wise, but at least it allows users to add request information to their logs without having to set the log level to DEBUG. Close tower-rs#123
Those no longer need to be speicified explicitly in recent versions of rustdoc.
|
Rebased on top of master (no changes were necessary). Added changelog entry as requested. Did not address the review comment, as I disagree with the request (see comment there). |
|
@hannobraun Sorry for the delay on this. I think it looks good as is 😊 Do you wanna merge/rebase master? I would like to include this in 0.1.2 which I'm hoping to release next week. |
|
@hannobraun Thanks for working on this! Sorry for taking so long with reviews. |
|
Looks like you got it sorted before I had a chance to look into it. Thanks! And don't worry about the time it took. There are only so many hours in the day, after all 😁 |
Motivation
I want to see the request method and path in my log message. See #123 for more information.
Solution
This is a minimally invasive solution for #123: It allows the user to configure the level for request spans. While this is far from ideal API-wise, it's a quick fix. I don't think I know enough about how Tracing is supposed to be used to come up with something better right now (that spans have associated levels in the first place seems wrong to me, but I'm sure I'm missing something).