feat: add SSE compression exclusion within default predicate #465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Discussed in this Github discussion from Axum's repo:
And had opened a docs PR within Axum's repo to add a note about compression for SSEs:
If not careful or properly handled, general compression with SSE will result in missing some or all events.
Solution
Exclude SSEs from being compressed by checking the content type of
text/event-stream
within theDefaultPredicate