Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal version checking to CI #433

Closed
jonhoo opened this issue Apr 2, 2020 · 3 comments
Closed

Add minimal version checking to CI #433

jonhoo opened this issue Apr 2, 2020 · 3 comments
Labels
C-request Category: A non-feature request, e.g.: metadata updates, optimization suggestion, etc. E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Experience needed to fix: Medium / intermediate P-low Low priority T-ci Topic: continuous integration
Milestone

Comments

@jonhoo
Copy link
Collaborator

jonhoo commented Apr 2, 2020

We should run cargo check (note, not cargo test) with both the minimal supported Rust version, and with -Z minimal-versions.

@jonhoo jonhoo added E-help-wanted Call for participation: Help is requested to fix this issue. P-low Low priority E-medium Call for participation: Experience needed to fix: Medium / intermediate T-ci Topic: continuous integration C-request Category: A non-feature request, e.g.: metadata updates, optimization suggestion, etc. labels Apr 2, 2020
@jonhoo jonhoo added this to the v0.4 milestone Apr 2, 2020
@hawkw
Copy link
Member

hawkw commented Jan 12, 2021

is this sufficient to close this?

rust: [stable, beta, nightly, 1.40.0]

@jonhoo
Copy link
Collaborator Author

jonhoo commented Jan 13, 2021

That will also run cargo test, which is probably stricter than we need (requiring 1.40 in tests seems unnecessary). -Z minimal-versions is also a good thing to run with, though that doesn't specifically need to be on msrv.

@davidpdrsn davidpdrsn modified the milestones: v0.4, 0.5 Mar 1, 2021
@davidpdrsn
Copy link
Member

This was fixed in #605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-request Category: A non-feature request, e.g.: metadata updates, optimization suggestion, etc. E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Experience needed to fix: Medium / intermediate P-low Low priority T-ci Topic: continuous integration
Projects
None yet
Development

No branches or pull requests

3 participants