Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out our CI never ran for 1.40. We were missing
override: true
🥲After actually running the tests on 1.40 it turns out we require 1.46 because of tokio and http. Tokio requires 1.45 and http requires 1.46 because of
if
/match
inconst fn
.http
is only used in tests so we could pin that to 0.2.4 which works on 1.45 but I guess since we might as well go to 1.46.Questions:
util::Either
to pin-project-lite?I also changed
rustdoc::broken_intra_doc_links
to only be set on CI withRUSTDOCFLAGS
.Fixes #604