Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Default Implementations for DirectService #150

Closed

Conversation

davidbarsky
Copy link
Contributor

This might make the task described in #136 easier. Namely, this addresses some of the “complexity” for services that don't need to spawn long-running futures, such as Buffer, certain kinds of middleware, and leaf services.

Note: this will need to be rebased atop of #149 to build successfully.

@davidbarsky
Copy link
Contributor Author

Closing because:

  • There's no mechanism of taking back a default in a library without a breaking change.
  • Helper functions provide the same or greater degree of utility as default implementations while avoiding a large number of rakes.

@davidbarsky davidbarsky deleted the introduce-default-impls-for-direct-service branch January 18, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant