Update tower-balance to std::future #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonhoo
commented
Sep 10, 2019
| @@ -88,7 +98,7 @@ where | |||
|
|
|||
| impl<D, Req> Balance<D, Req> | |||
| where | |||
| D: Discover, | |||
| D: Discover + Unpin, | |||
There was a problem hiding this comment.
This makes me really sad, but it is required since we need to call Discover::poll_discover (which takes Pin<&mut Self>) from Service::poll_ready (which takes &mut Self).
There was a problem hiding this comment.
Yeah, this is fine 👍 can we make sure we have docs on why this is required maybe, just point people to that issue and what they can do to get Unpin (aka box the discover)?
jonhoo
force-pushed
the
jonhoo/update-balance
branch
from
34ba7be to
1b63bbf
Compare
LucioFranco
approved these changes
Sep 10, 2019
| @@ -88,7 +98,7 @@ where | |||
|
|
|||
| impl<D, Req> Balance<D, Req> | |||
| where | |||
| D: Discover, | |||
| D: Discover + Unpin, | |||
There was a problem hiding this comment.
Yeah, this is fine 👍 can we make sure we have docs on why this is required maybe, just point people to that issue and what they can do to get Unpin (aka box the discover)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will rebase and mark as ready once #330 lands (which this depends on)
This also includes a small patch to
tower-discoverto delegate theDiscovertrait throughPin<D>whereD::Target: Discover(so we can use it through, say,Pin<Box<>>), and a patch totower-loadto makeConstant: Debug.