Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layer: Implement Layer for tuples of up to 16 elements #694

Merged
merged 3 commits into from
Oct 4, 2022
Merged

layer: Implement Layer for tuples of up to 16 elements #694

merged 3 commits into from
Oct 4, 2022

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Sep 28, 2022

@LucioFranco
Copy link
Member

Seems really cool! I would love to seem some examples with it.

@jplatte
Copy link
Contributor Author

jplatte commented Sep 28, 2022 •
edited
Loading

Okay, I updated the first commit to be more consistent (I had a few TNs instead of LNs) and then added a new commit for the reversed order as dicussed on Discord. Like that, it's easy to reverse-apply the second commit to change the order later, if wanted 🙂

@davidpdrsn
Copy link
Member

Sweet! I can confirm that it matches ServerBuilder now.

@davidpdrsn davidpdrsn added C-enhancement Category: A PR with an enhancement or a proposed on in an issue. A-layer Area: The tower `Layer` trait labels Sep 28, 2022
@jplatte
Copy link
Contributor Author

jplatte commented Oct 4, 2022

Anything that still needs to happen before this can be merged?

davidpdrsn
davidpdrsn approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope I think it's good to go :)

@davidpdrsn davidpdrsn enabled auto-merge (squash) October 4, 2022 18:50
@davidpdrsn davidpdrsn merged commit 87fa8ef into tower-rs:master Oct 4, 2022
@jplatte jplatte deleted the tuple-layer branch October 4, 2022 19:14
davidpdrsn pushed a commit that referenced this pull request Oct 7, 2022
@jplatte @davidpdrsn
layer: Implement Layer for tuples of up to 16 elements (#694)
66010c1
@davidpdrsn davidpdrsn mentioned this pull request Oct 7, 2022
Merged
@jplatte jplatte mentioned this pull request Oct 11, 2022
Merged
@hlbarber hlbarber mentioned this pull request Nov 13, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
A-layer Area: The tower `Layer` trait C-enhancement Category: A PR with an enhancement or a proposed on in an issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jplatte @LucioFranco @davidpdrsn