Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes on popovers #47

Closed
5 tasks done
pdvorchik opened this issue Feb 18, 2017 · 4 comments
Closed
5 tasks done

Bug fixes on popovers #47

pdvorchik opened this issue Feb 18, 2017 · 4 comments
Assignees
Labels

Comments

@pdvorchik
Copy link
Collaborator

pdvorchik commented Feb 18, 2017

Basic maintenance work on the popovers:

  • Close existing googlemaps popover when opening a new one, to prevent overlaps that make it unreadable.
  • Upcoming Events popover should say "There are no notes for this event." instead of being blank if the notes field is empty.
  • Upcoming Events popover should behave consistently. When toggling between rows there's different behavior depending on if you click the text, the td, or the padding. All three should behave the same way.
  • Clicking out side of the upcoming events table should dismiss any open upcoming events popover. Going with close buttons instead, as that's how the map popovers work and I'd like to keep things from getting more divergent.
  • Standardize min width so they look more consistent.
@pdvorchik pdvorchik added the bug label Feb 18, 2017
@meganrm
Copy link
Collaborator

meganrm commented Feb 19, 2017

"Upcoming Events popover should behave consistently. When toggling between rows there's different behavior depending on if you click the text, the td, or the padding. All three should behave the same way." I don't understand this.... for me the anywhere within the tr (including the text and the padding) toggles the popover... what are you seeing?

@pdvorchik
Copy link
Collaborator Author

I'm still trying to isolate the cause -- so I can't say for 100% sure thati t's the padding yet. But I'm seeing at least two different bugs here:

  1. Click on one row to open up the popover. Click on a different row right above the text. If you hit the right spot it'll close the first popover but not open the second one.

  2. It's possible to open multiple popovers, though I haven't figured out what exactly the failure cases are in this context.
    double-popover

I'm testing on Win10 with Chrome, FF, and Edge

@meganrm
Copy link
Collaborator

meganrm commented Feb 19, 2017

Ok thanks!

@pdvorchik
Copy link
Collaborator Author

Turns out it's a bug in boostrap 3...go figure. Good news is that there's a simple fix. twbs/bootstrap#16732

@pdvorchik pdvorchik self-assigned this Feb 19, 2017
meganrm added a commit that referenced this issue Feb 19, 2017
@meganrm meganrm closed this as completed Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants