Refactor to modern Kotlin idioms and fix deprecated API #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace deprecated MessageType.INFO with NotificationType.INFORMATION - Use Kotlin property syntax (file.path instead of file.getPath()) - Replace nested null checks with scope functions (?.let, takeIf) - Replace try-catch with runCatching for cleaner error handling - Add version caching to VenvProjectViewNodeDecorator for performance - Remove unnecessary @JvmStatic annotations (no Java callers)
Unit tests for VenvUtils: - Test getPythonVersionFromPyVenv with valid/invalid/missing files - Test version parsing with edge cases (trimming, equals signs) Unit tests for VenvProjectViewNodeDecorator: - Test decoration with valid venv directories - Test no decoration for non-venv files - Verify version caching behavior Additional UI test scenarios: - Test Python version display in project tree - Test venv icon decoration - Test context menu behavior on non-venv items Dependencies: - Add mockk for mocking IntelliJ classes in unit tests
gaborbernat
added a commit
to gaborbernat/PyVenvManage
that referenced
this pull request
Jan 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize the codebase with idiomatic Kotlin patterns, fix deprecated IntelliJ API usage, and add comprehensive test coverage.
Changes
Deprecated API Fix
MessageType.INFOwithNotificationType.INFORMATIONin notificationsKotlin Idioms
file.pathinstead offile.getPath(),node.virtualFileinstead ofnode.getVirtualFile()?.let,takeIf)try-catchwithrunCatchingfor cleaner error handling@JvmStaticannotations (no Java callers in the codebase)Performance
ConcurrentHashMapcache toVenvProjectViewNodeDecoratorto avoid re-readingpyvenv.cfgfiles on every tree renderTest Coverage
Added comprehensive unit tests and UI tests:
VenvUtilsTestVenvProjectViewNodeDecoratorTestUITest(new scenarios)New test scenarios: