New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow working without ctypes #275

Merged

gaborbernat merged 1 commit into tox-dev:main from youknowone:windows-ctypes

Apr 23, 2024

Contributor

youknowone commented Apr 19, 2024

ctypes in windows is perfectly optional, but it doesn't fall back to other methods when import ctypes fails.

youknowone requested review from gaborbernat, ofek, Julian and RonnyPfannschmidt as code owners

April 19, 2024 13:44

gaborbernat requested changes

View reviewed changes

Member

gaborbernat left a comment

Test please

youknowone force-pushed the windows-ctypes branch 2 times, most recently from a15c2d9 to 7adab13 Compare

April 21, 2024 12:37

youknowone changed the title ~~Allow windows without ctypes environment~~ Allow working without ctypes

youknowone force-pushed the windows-ctypes branch 4 times, most recently from e6d0bc1 to a6e2dfd Compare

April 21, 2024 13:00

Contributor Author

youknowone commented Apr 21, 2024

Thanks! I added test for all platforms to prevent regression because other platforms are already safe to work without ctypes

gaborbernat approved these changes

View reviewed changes

gaborbernat enabled auto-merge (squash)

April 21, 2024 16:02

ofek previously approved these changes

View reviewed changes

Collaborator

ofek left a comment

LGTM as a Windows user

gaborbernat requested changes

View reviewed changes

Member

gaborbernat left a comment

Type checker fail


          Allow windows without ctypes environment

a6376be

auto-merge was automatically disabled

April 21, 2024 23:27

Head branch was pushed to by a user without write access

youknowone dismissed ofek’s stale review via

a6376be

April 21, 2024 23:28

youknowone force-pushed the windows-ctypes branch from a6e2dfd to a6376be Compare

April 21, 2024 23:28

RonnyPfannschmidt approved these changes

View reviewed changes

gaborbernat approved these changes

View reviewed changes

Member

gaborbernat left a comment

gaborbernat merged commit b44d57d into tox-dev:main

29 checks passed

alicejli referenced this pull request in googleapis/sdk-platform-java


          deps: update dependency platformdirs to v4.2.1 (#2662)

dbdcc91

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [platformdirs](https://togithub.com/platformdirs/platformdirs) |
`==4.1.0` -> `==4.2.1` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/platformdirs/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/platformdirs/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/platformdirs/4.1.0/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/platformdirs/4.1.0/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>platformdirs/platformdirs (platformdirs)</summary>

###
[`v4.2.1`](https://togithub.com/platformdirs/platformdirs/releases/tag/4.2.1)

[Compare
Source](https://togithub.com/platformdirs/platformdirs/compare/4.2.0...4.2.1)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- Switch to ruff for formatting and use codespell and docformatter by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[https://github.com/platformdirs/platformdirs/pull/261](https://togithub.com/platformdirs/platformdirs/pull/261)
- Use hatch over tox by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[https://github.com/platformdirs/platformdirs/pull/262](https://togithub.com/platformdirs/platformdirs/pull/262)
- chore: various minor fixes by
[@&#8203;deronnax](https://togithub.com/deronnax) in
[https://github.com/platformdirs/platformdirs/pull/263](https://togithub.com/platformdirs/platformdirs/pull/263)
- chore: update dead Microsoft's known folders documentation link by
[@&#8203;deronnax](https://togithub.com/deronnax) in
[https://github.com/platformdirs/platformdirs/pull/267](https://togithub.com/platformdirs/platformdirs/pull/267)
- Allow working without ctypes by
[@&#8203;youknowone](https://togithub.com/youknowone) in
[https://github.com/platformdirs/platformdirs/pull/275](https://togithub.com/platformdirs/platformdirs/pull/275)

#### New Contributors

- [@&#8203;deronnax](https://togithub.com/deronnax) made their first
contribution in
[https://github.com/platformdirs/platformdirs/pull/263](https://togithub.com/platformdirs/platformdirs/pull/263)
- [@&#8203;youknowone](https://togithub.com/youknowone) made their first
contribution in
[https://github.com/platformdirs/platformdirs/pull/275](https://togithub.com/platformdirs/platformdirs/pull/275)

**Full Changelog**:
tox-dev/platformdirs@4.2.0...4.2.1

###
[`v4.2.0`](https://togithub.com/platformdirs/platformdirs/releases/tag/4.2.0)

[Compare
Source](https://togithub.com/platformdirs/platformdirs/compare/4.1.0...4.2.0)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- Fix 2 typos about XDG_DATA_DIR by
[@&#8203;Freed-Wu](https://togithub.com/Freed-Wu) in
[https://github.com/platformdirs/platformdirs/pull/256](https://togithub.com/platformdirs/platformdirs/pull/256)
- Add convenience methods to `PlatformDirsAPI` that allow iterating over
both user and site dirs/paths. by
[@&#8203;SpaceshipOperations](https://togithub.com/SpaceshipOperations)
in
[https://github.com/platformdirs/platformdirs/pull/258](https://togithub.com/platformdirs/platformdirs/pull/258)

#### New Contributors

-
[@&#8203;SpaceshipOperations](https://togithub.com/SpaceshipOperations)
made their first contribution in
[https://github.com/platformdirs/platformdirs/pull/258](https://togithub.com/platformdirs/platformdirs/pull/258)

**Full Changelog**:
tox-dev/platformdirs@4.1.0...4.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: Alice <65933803+alicejli@users.noreply.github.com>

youknowone deleted the windows-ctypes branch

May 20, 2024 10:26

This was referenced May 20, 2024

Failed to get-pip on Windows RustPython/RustPython#5146

Closed

Tracking pip support in RustPython RustPython/RustPython#5332

Open

lqiu96 referenced this pull request in googleapis/sdk-platform-java


          deps: update dependency platformdirs to v4.2.1 (#2662)

a88ed7a

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [platformdirs](https://togithub.com/platformdirs/platformdirs) |
`==4.1.0` -> `==4.2.1` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/platformdirs/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/platformdirs/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/platformdirs/4.1.0/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/platformdirs/4.1.0/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>platformdirs/platformdirs (platformdirs)</summary>

###
[`v4.2.1`](https://togithub.com/platformdirs/platformdirs/releases/tag/4.2.1)

[Compare
Source](https://togithub.com/platformdirs/platformdirs/compare/4.2.0...4.2.1)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- Switch to ruff for formatting and use codespell and docformatter by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[https://github.com/platformdirs/platformdirs/pull/261](https://togithub.com/platformdirs/platformdirs/pull/261)
- Use hatch over tox by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[https://github.com/platformdirs/platformdirs/pull/262](https://togithub.com/platformdirs/platformdirs/pull/262)
- chore: various minor fixes by
[@&#8203;deronnax](https://togithub.com/deronnax) in
[https://github.com/platformdirs/platformdirs/pull/263](https://togithub.com/platformdirs/platformdirs/pull/263)
- chore: update dead Microsoft's known folders documentation link by
[@&#8203;deronnax](https://togithub.com/deronnax) in
[https://github.com/platformdirs/platformdirs/pull/267](https://togithub.com/platformdirs/platformdirs/pull/267)
- Allow working without ctypes by
[@&#8203;youknowone](https://togithub.com/youknowone) in
[https://github.com/platformdirs/platformdirs/pull/275](https://togithub.com/platformdirs/platformdirs/pull/275)

#### New Contributors

- [@&#8203;deronnax](https://togithub.com/deronnax) made their first
contribution in
[https://github.com/platformdirs/platformdirs/pull/263](https://togithub.com/platformdirs/platformdirs/pull/263)
- [@&#8203;youknowone](https://togithub.com/youknowone) made their first
contribution in
[https://github.com/platformdirs/platformdirs/pull/275](https://togithub.com/platformdirs/platformdirs/pull/275)

**Full Changelog**:
tox-dev/platformdirs@4.2.0...4.2.1

###
[`v4.2.0`](https://togithub.com/platformdirs/platformdirs/releases/tag/4.2.0)

[Compare
Source](https://togithub.com/platformdirs/platformdirs/compare/4.1.0...4.2.0)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- Fix 2 typos about XDG_DATA_DIR by
[@&#8203;Freed-Wu](https://togithub.com/Freed-Wu) in
[https://github.com/platformdirs/platformdirs/pull/256](https://togithub.com/platformdirs/platformdirs/pull/256)
- Add convenience methods to `PlatformDirsAPI` that allow iterating over
both user and site dirs/paths. by
[@&#8203;SpaceshipOperations](https://togithub.com/SpaceshipOperations)
in
[https://github.com/platformdirs/platformdirs/pull/258](https://togithub.com/platformdirs/platformdirs/pull/258)

#### New Contributors

-
[@&#8203;SpaceshipOperations](https://togithub.com/SpaceshipOperations)
made their first contribution in
[https://github.com/platformdirs/platformdirs/pull/258](https://togithub.com/platformdirs/platformdirs/pull/258)

**Full Changelog**:
tox-dev/platformdirs@4.1.0...4.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: Alice <65933803+alicejli@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet