Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
types
module has a bunch of things likeModuleType
:ModuleType.__module__
is"builtins" and
ModuleType.__name__
is "module", but it should be referenced astypes.ModuleType
.To deal with these, I made a dict of values exported from
types
to the export name. If an annotationis in this dict, we use "types" as the module and the reported name as the name.
I also made a couple of nonfunctional changes:
_is_newtype
is more readable as a separate method so I factored it out.test_parse_annotation
displays more useful error messages if we assert two tuples are equal than if we make three sequential assertions -- this way we can see if more than one are wrong.