Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PEP 735 dependency-groups #16

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

browniebroke
Copy link
Contributor

@browniebroke browniebroke commented Oct 25, 2024

Dependency groups (PEP 735) has just landed in uv and got exclited to try it out on one of my projects, but noticed that the group ended up lost in the middle of the linters table. Putting it right after the project table seems like the most obvious place...

That seems to do the trick, but let me know if I missed anything (it's my first PR in 🦀)

@gaborbernat
Copy link
Member

While we are at it, we should sort the keys inside this table alphabetically.

@browniebroke browniebroke force-pushed the feat/dependency-groups branch 2 times, most recently from 9a422e3 to 36b0a0f Compare October 26, 2024 11:45
@gaborbernat gaborbernat force-pushed the feat/dependency-groups branch 2 times, most recently from 1605f2d to c285f42 Compare October 30, 2024 05:30
@gaborbernat
Copy link
Member

Ok, looks alright now. Thanks for the contribution, well done for your first PR.

Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat force-pushed the feat/dependency-groups branch from c285f42 to a748cba Compare October 30, 2024 05:33
@gaborbernat gaborbernat merged commit 3451bca into tox-dev:main Oct 30, 2024
43 checks passed
@browniebroke browniebroke deleted the feat/dependency-groups branch October 30, 2024 07:11
@browniebroke
Copy link
Contributor Author

Thanks for getting it over the line!

@gaborbernat
Copy link
Member

Shipped https://pypi.org/project/pyproject-fmt/2.5.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants